From owner-cvs-all Sun Jan 26 14: 9:37 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2DB7437B405; Sun, 26 Jan 2003 14:09:36 -0800 (PST) Received: from k6.locore.ca (k6.locore.ca [198.96.117.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEC0643F18; Sun, 26 Jan 2003 14:09:34 -0800 (PST) (envelope-from jake@k6.locore.ca) Received: from k6.locore.ca (jake@localhost.locore.ca [127.0.0.1]) by k6.locore.ca (8.12.6/8.12.6) with ESMTP id h0QMBnjb083085; Sun, 26 Jan 2003 17:11:49 -0500 (EST) (envelope-from jake@k6.locore.ca) Received: (from jake@localhost) by k6.locore.ca (8.12.6/8.12.6/Submit) id h0QMBn36083084; Sun, 26 Jan 2003 17:11:49 -0500 (EST) Date: Sun, 26 Jan 2003 17:11:49 -0500 From: Jake Burkholder To: David Xu Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha trap.c vm_machdep.c src/sys/ddb db_ps.c src/sys/i386/i386 critical.c exception.s genassym.c trap.c vm_machdep.c src/sys/ia64/ia64 trap.c vm_machdep.c src/sys/kern init_main.c kern_clock.c kern_exec.c kern_exit.c kern_fork.c ... Message-ID: <20030126171149.B79685@locore.ca> References: <200301261141.h0QBfZxZ001813@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200301261141.h0QBfZxZ001813@repoman.freebsd.org>; from davidxu@FreeBSD.org on Sun, Jan 26, 2003 at 03:41:35AM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Apparently, On Sun, Jan 26, 2003 at 03:41:35AM -0800, David Xu said words to the effect of; > davidxu 2003/01/26 03:41:35 PST > > Modified files: > sys/alpha/alpha trap.c vm_machdep.c > sys/ddb db_ps.c > sys/i386/i386 critical.c exception.s genassym.c trap.c > vm_machdep.c > sys/ia64/ia64 trap.c vm_machdep.c > sys/kern init_main.c kern_clock.c kern_exec.c > kern_exit.c kern_fork.c kern_lock.c > kern_resource.c kern_sig.c kern_switch.c > kern_thread.c subr_prof.c subr_trap.c > subr_witness.c > sys/powerpc/powerpc vm_machdep.c > sys/sparc64/sparc64 trap.c vm_machdep.c > sys/sys buf.h lockmgr.h proc.h resourcevar.h > systm.h > Log: > Move UPCALL related data structure out of kse, introduce a new > data structure called kse_upcall to manage UPCALL. All KSE binding > and loaning code are gone. > Ok, this change should have had much more significant review and testing. A lot of things were broken by this commit, and a lot of changes were made which are not mentioned in the commit message, should have been committed separately, and should have had more review than just julian. The part that I care about is the profiling changes. The TDF_ASTPENDING flag is not tested on anyhting but x86, which breaks userland profiling on all other architectures. I don't see how this change can have had significant testing given that you don't have sufficient infrastructure to test profiling of non-trivial threaded programs. In addition, this blocks getting addupc_intr out of sched_lock for non-threaded processes. Please back this part out and re-implement it in a way that does not break profiling for other architectures, and that does not require sched_lock to be held accross addupc_intr for threaded processes. The only way I can see to do that is with per-thread profiling buffers. Jake To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message