From owner-svn-src-head@FreeBSD.ORG Mon Aug 19 11:44:12 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0D737370; Mon, 19 Aug 2013 11:44:12 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 02DCE289A; Mon, 19 Aug 2013 11:44:10 +0000 (UTC) Received: from alph.d.allbsd.org (p2049-ipbf1102funabasi.chiba.ocn.ne.jp [122.26.101.49]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r7JBhpnt099200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Aug 2013 20:44:01 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r7JBhpkN082851; Mon, 19 Aug 2013 20:43:51 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 19 Aug 2013 20:43:30 +0900 (JST) Message-Id: <20130819.204330.2144498109880721402.hrs@allbsd.org> To: pjd@FreeBSD.org Subject: Re: svn commit: r254484 - head/lib/libc/net From: Hiroki Sato In-Reply-To: <201308181038.r7IAcxkM008487@svn.freebsd.org> References: <201308181038.r7IAcxkM008487@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Aug_19_20_43_30_2013_401)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 19 Aug 2013 20:44:02 +0900 (JST) X-Spam-Status: No, score=-90.6 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,RCVD_IN_PBL,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2013 11:44:12 -0000 ----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Pawel Jakub Dawidek wrote in <201308181038.r7IAcxkM008487@svn.freebsd.org>: pj> Author: pjd pj> Date: Sun Aug 18 10:38:59 2013 pj> New Revision: 254484 pj> URL: http://svnweb.freebsd.org/changeset/base/254484 pj> pj> Log: pj> Consistently use 'af' as an argument name for address family. pj> Now both gethostbyname2(3) and gethostbyaddr(3) use the same argument name. pj> The same argument name is also used in implementations of those functions. pj> pj> Modified: pj> head/lib/libc/net/gethostbyname.3 pj> pj> Modified: head/lib/libc/net/gethostbyname.3 pj> ============================================================================== pj> --- head/lib/libc/net/gethostbyname.3 Sun Aug 18 10:33:46 2013 (r254483) pj> +++ head/lib/libc/net/gethostbyname.3 Sun Aug 18 10:38:59 2013 (r254484) pj> @@ -51,7 +51,7 @@ pj> .Ft struct hostent * pj> .Fn gethostbyname2 "const char *name" "int af" pj> .Ft struct hostent * pj> -.Fn gethostbyaddr "const void *addr" "socklen_t len" "int type" pj> +.Fn gethostbyaddr "const void *addr" "socklen_t len" "int af" pj> .Ft struct hostent * pj> .Fn gethostent void pj> .Ft void pj> @@ -107,7 +107,7 @@ in binary form pj> .Tn ASCII pj> form). pj> The pj> -.Fa type pj> +.Fa af pj> argument specifies the address family pj> (e.g.\& pj> .Dv AF_INET , AF_INET6 , I do not think we need to change this for consistency between the manual page and its implementation. gethostbyaddr()'s "int type" appears literally in POSIX and almost all systems have used that definition for a long time. -- Hiroki ----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlISBOIACgkQTyzT2CeTzy2TzgCggcC9opOtNYppEufIHGVM4UCK tIUAn23y+5/RmqL9A53XWYZeUpiTEKwT =ATQ/ -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Aug_19_20_43_30_2013_401)----