Date: Sun, 17 Jul 2022 21:50:09 +0000 From: Lorenzo Salvadore <phascolarctos@protonmail.ch> To: =?utf-8?Q?Stefan_E=C3=9Fer?= <se@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 973550dd663c - main - Revert "devel/wasi-compiler-rt14: add new port" Message-ID: <EsY3E7mQ41u5OlOFMnySrNg6q6Om_X5GUqcrZbVTkjgQ-jSde3svhsVITtyPmZkuZ3b05c-TA_qz4W7gPWj-VrXp-nFA57j2Nuumz0_SDZM=@protonmail.ch> In-Reply-To: <4681c6a9-f10e-2cd8-0339-b480b1f52c01@FreeBSD.org> References: <202207171701.26HH10PP074399@gitrepo.freebsd.org> <mzBXzeUu891XZf5Aj8_AjLa4e2bEljocSbxJbzhl8twSiV39qezNzuvAjr_zWw2q4v8MJxpEBhPsQmNgjlOvMvVCDl-XZa6CxWrTa8o0DFI=@protonmail.ch> <4681c6a9-f10e-2cd8-0339-b480b1f52c01@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
------- Original Message ------- On Sunday, July 17th, 2022 at 22:55, Stefan E=C3=9Fer <se@FreeBSD.org> wrot= e: > > > Am 17.07.22 um 19:54 schrieb Lorenzo Salvadore:> I think the commit below > > requires to add any entry to MOVED, as it actually > > > removed a port that existed, even if only for a short while and by mist= ake. > > > I'd agree in general, but do not think so in this special case. > > The port had not been added to be built (despite having been built tested= on > amd64 an di386 on several FreeBSD releases), but only to allow "make inde= x" > to succeed on a system that defines LLVM_DEFAULT=3D14. > > There is no way a working firefox with WASI support could have been built > with LLVM-14 at this time, since there are unresolved issues that still > need to be fixed. > > And the firefox port has been changed to require LLVM-13 and the matching > dependencies (like wasi-compiler-rt13). > > Even if this port has been installed on a system, I do not see how it cou= ld > cause issue. If wasi-compiler-rt14 is committed again at a later time, it > will have a higher minor version and any remains of the reverted port wil= l > just be replaced by an update to the new version. > > > If you insist that a MOVED entry must still be created. this can of cours= e > be done. But I'll not feel responsible to remove it when WASI can be buil= t > with LLVM-14. I don't insist as I don't know the ports infrastructure deeply enough to understand if this case is special enough to avoid the MOVED entry, but I encourage you to double check, in case there is some tool that expects to find that line. Cheers, Lorenzo Salvadore
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EsY3E7mQ41u5OlOFMnySrNg6q6Om_X5GUqcrZbVTkjgQ-jSde3svhsVITtyPmZkuZ3b05c-TA_qz4W7gPWj-VrXp-nFA57j2Nuumz0_SDZM=>