Date: Sun, 27 May 2018 07:06:24 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r470953 - head/x11/xorg-minimal Message-ID: <d0xh-sn5b-wny@FreeBSD.org> In-Reply-To: <201805270424.w4R4Ok4J036817@repo.freebsd.org> (Eitan Adler's message of "Sun, 27 May 2018 04:24:46 %2B0000 (UTC)") References: <201805270424.w4R4Ok4J036817@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Eitan Adler <eadler@FreeBSD.org> writes:
> .elif ${VIDEO_DRIVER} == "intel29"
> -RUN_DEPENDS+= ${LOCALBASE}/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-${VIDEO_DRIVER}
> +RUN_DEPENDS+= ${LOCALBASE}/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-intel
Why maintain a compatibility kludge for systems that have reached EOL?
Maybe document the change in UPDATING instead.
> +.elif ${VIDEO_DRIVER} == "intel"
> +RUN_DEPENDS+= ${LOCALBASE}/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
> .else
> RUN_DEPENDS+= ${LOCALBASE}/lib/xorg/modules/drivers/${VIDEO_DRIVER}_drv.so:x11-drivers/xf86-video-${VIDEO_DRIVER}
> -.endif
> -
> -.if ${VIDEO_DRIVER} == intel
> -RUN_DEPENDS+= ${LOCALBASE}/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
> .endif
Did you intentionally remove DDX dependency for VIDEO_DRIVER=intel?
Before:
$ make -V RUN_DEPENDS:M\*intel\* VIDEO_DRIVER=intel
/usr/local/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-intel /usr/local/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
After:
$ make -V RUN_DEPENDS:M\*intel\* VIDEO_DRIVER=intel
/usr/local/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0xh-sn5b-wny>