From owner-svn-ports-all@freebsd.org  Sun May 27 05:06:30 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08CEEF7AB5C;
 Sun, 27 May 2018 05:06:30 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A99596F96E;
 Sun, 27 May 2018 05:06:29 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 8DA8A1D6AD; Sun, 27 May 2018 05:06:29 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Eitan Adler <eadler@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r470953 - head/x11/xorg-minimal
References: <201805270424.w4R4Ok4J036817@repo.freebsd.org>
Date: Sun, 27 May 2018 07:06:24 +0200
In-Reply-To: <201805270424.w4R4Ok4J036817@repo.freebsd.org> (Eitan Adler's
 message of "Sun, 27 May 2018 04:24:46 +0000 (UTC)")
Message-ID: <d0xh-sn5b-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2018 05:06:30 -0000

Eitan Adler <eadler@FreeBSD.org> writes:

>  .elif ${VIDEO_DRIVER} == "intel29"
> -RUN_DEPENDS+=	${LOCALBASE}/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-${VIDEO_DRIVER}
> +RUN_DEPENDS+=	${LOCALBASE}/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-intel

Why maintain a compatibility kludge for systems that have reached EOL?
Maybe document the change in UPDATING instead.

> +.elif ${VIDEO_DRIVER} == "intel"
> +RUN_DEPENDS+=	${LOCALBASE}/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
>  .else
>  RUN_DEPENDS+=	${LOCALBASE}/lib/xorg/modules/drivers/${VIDEO_DRIVER}_drv.so:x11-drivers/xf86-video-${VIDEO_DRIVER}
> -.endif
> -
> -.if ${VIDEO_DRIVER} == intel
> -RUN_DEPENDS+=	${LOCALBASE}/lib/va/i965_drv_video.so:multimedia/libva-intel-driver
>  .endif

Did you intentionally remove DDX dependency for VIDEO_DRIVER=intel?

Before:
  $ make -V RUN_DEPENDS:M\*intel\* VIDEO_DRIVER=intel
  /usr/local/lib/xorg/modules/drivers/intel_drv.so:x11-drivers/xf86-video-intel /usr/local/lib/va/i965_drv_video.so:multimedia/libva-intel-driver

After:
  $ make -V RUN_DEPENDS:M\*intel\* VIDEO_DRIVER=intel
  /usr/local/lib/va/i965_drv_video.so:multimedia/libva-intel-driver