Date: Mon, 20 Feb 2006 10:38:00 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Peter Jeremy <peterjeremy@optushome.com.au>, freebsd-current@freebsd.org Subject: Re: It still here... panic: ufs_dirbad: bad dir Message-ID: <200602201838.k1KIc0CG041575@apollo.backplane.com> References: <20060102222723.GA1754@dragon.NUXI.org> <200602180439.k1I4drNm010220@apollo.backplane.com> <20060218064523.GA684@turion.vk2pj.dyndns.org> <200602180742.k1I7g3XA012241@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Could someone familiar with softupdates take a look at line 902
of kern/vfs_cluster.c?
There is a call to buf_start(tbp) there, but then just after that
in the B_VMIO code there is a brelse() call if one of the pages
making up the buffer is BUSY. A brelse() call there, after the
call to buf_start(), could leave the buffer in a very sad state
indeed!
It seems to me that that buf_start() call needs to be moved to
around line 949, after the VM check and just before the tbp is
added to the cluster list.
-Matt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602201838.k1KIc0CG041575>