From owner-svn-src-head@freebsd.org Fri Jun 3 14:23:00 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E856B6848F for ; Fri, 3 Jun 2016 14:23:00 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95576189A for ; Fri, 3 Jun 2016 14:22:59 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: ac906def-2996-11e6-ac92-3142cfe117f2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.eu.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 3 Jun 2016 14:22:59 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u53EMq2D000989; Fri, 3 Jun 2016 08:22:52 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1464963772.1204.195.camel@freebsd.org> Subject: Re: svn commit: r301266 - head/sys/arm/freescale/imx From: Ian Lepore To: Andrew Turner , Svatopluk Kraus Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 03 Jun 2016 08:22:52 -0600 In-Reply-To: <20160603134031.7a038244@zapp> References: <201606031105.u53B5tVi073576@repo.freebsd.org> <20160603134031.7a038244@zapp> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 14:23:00 -0000 On Fri, 2016-06-03 at 13:40 +0100, Andrew Turner wrote: > On Fri, 3 Jun 2016 11:05:55 +0000 (UTC) > Svatopluk Kraus wrote: > > > Author: skra > > Date: Fri Jun 3 11:05:55 2016 > > New Revision: 301266 > > URL: https://svnweb.freebsd.org/changeset/base/301266 > > > > Log: > > Postpone allocation of IRQ resource to the time when interrupt > > controller devices are attached. This has already been done for > > bus_setup_intr(). > > > > There was no doubt that if someone wants to setup an interrupt, > > corresponding interrupt controller device must already be > > attached. > > However, the same must be valid for allocation of an interrupt > > resource unless the allocation is done blindly, without any > > information that such interrupt even exists. While it was done this > > blind way before, it won't be possible after next INTRNG change. > > > > Modified: > > head/sys/arm/freescale/imx/imx6_anatop.c > > > > Modified: head/sys/arm/freescale/imx/imx6_anatop.c > > =================================================================== > > =========== > > --- head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 > > 10:28:06 2016 (r301265) +++ > > head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 11:05:55 > > 2016 (r301266) @@ -78,7 +78,6 @@ __FBSDID("$FreeBSD$"); > > static struct resource_spec imx6_anatop_spec[] = { > > { SYS_RES_MEMORY, 0, RF_ACTIVE }, > > - { SYS_RES_IRQ, 0, RF_ACTIVE }, > > Why not mark it as optional? No point, really. The anatop driver attaches at BUS_PASS_BUS, way before interrupt controllers, so it's not like attach-time allocation will ever work, optional or not. (It's not a bus, it's a driver for regulators and some cpu/soc control stuff that almost every other driver will need, but we don't have a named bus pass early enough for that, other than _BUS). -- Ian