From owner-freebsd-hackers@FreeBSD.ORG Sun Jul 3 10:39:50 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4EB1F106566C; Sun, 3 Jul 2011 10:39:50 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 22E2C8FC13; Sun, 3 Jul 2011 10:39:50 +0000 (UTC) Received: by pzk27 with SMTP id 27so2082565pzk.13 for ; Sun, 03 Jul 2011 03:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=eA1z3W/Nh5N9YSwCST9aUHqoG2PxiOTEGBwkhZXV258=; b=LLD1IMfsrEibSRjw8ffzHQlBEnoAsSmtNQg5wvgR+oKQsfeHQ1aO+5laLBckYNYCdN ew1hWJUuu4kE55DqG4+q1LphSR8SA39Ywmhaj60dhL5P11gANeefej/UQsuRr0gxKj0q /zXqsDlC0/NsjksBKG/6iCJkZIqt32uF6nv54= MIME-Version: 1.0 Received: by 10.68.29.74 with SMTP id i10mr5805585pbh.69.1309689589759; Sun, 03 Jul 2011 03:39:49 -0700 (PDT) Sender: rmh.aybabtu@gmail.com Received: by 10.68.47.138 with HTTP; Sun, 3 Jul 2011 03:39:49 -0700 (PDT) In-Reply-To: <20110703020827.GA5763@sandvine.com> References: <20110702193724.5c55a6c9@kan.dnsalias.net> <20110703020827.GA5763@sandvine.com> Date: Sun, 3 Jul 2011 12:39:49 +0200 X-Google-Sender-Auth: OUuebO5hWn-TzOCcY8EFu6DJPuI Message-ID: From: Robert Millan To: Ed Maste Content-Type: text/plain; charset=UTF-8 Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] __FreeBSD_kernel__ X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jul 2011 10:39:50 -0000 2011/7/3 Ed Maste : >> Alternatively, you should provide the symbol in >> similar way in which we provide __FreeBSD_version, through well-known >> header like sys/param.h and not pollute GCC. > > I suspect this is probably a reasonable alternative, but may mean software > will have to pick up an additional #include. Having to pick up an additional #include is sometimes a source of trouble, because: a) it's easy to forget (and hard to detect when having forgotten only breaks the other platform) b) one might not be able to assume this file is present ( is not in POSIX, for example) Nevermind that, it's much better than not having the macro at all. -- Robert Millan