From nobody Sun Mar 29 18:24:21 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fkN7n5xQLz6X675 for ; Sun, 29 Mar 2026 18:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fkN7n5LtJz3Q9V for ; Sun, 29 Mar 2026 18:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774808661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gx5k1ECfOhsBlN1RAQ4RTscU4XLAoi7r+aBBfBVOqvs=; b=tKTEcuhUpDZnk0jvmeS24CMv/JQTO+6NBX/lNN5ong+PlHzU0WyMrcgXeec5Qn1MobWuY4 q37+jxlSYOe9Xx2Zqw/cpeD7UVYXTdiRwXm+rmNMGsrbUxfWu6bU1LpkrXfq9Ljyxii6wG zLGQvjiF0vRnfhzjo2/7HcJn9iSS/mVKPsr16gbkXfYtzOYtMLZd3kl7LzDYPvMnpYBwJj Ge79IK0y8+HbGlnFH0azcmaLWXtUMBwSxoIU7QjFVt5R3e9TVg5OtWtHg1cOv8j9KzD6dX zJZkBEeBd4kVhLSspl6SLbhco3iivqU67pITZrmJdOPlJpHCd5J3NKDsNYwPyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774808661; a=rsa-sha256; cv=none; b=oZumAbQxtVg/0i1fculBG0nHUZ6sgvd5Pr9IHXgWUYMwFX3jh5wKS3QnT65I7GSFuwWr5q w4rEBeM/ZE+E5qw6bV6MEpFCGKE/g6YX1Le+mYI4hTxYtzJrm15Wa4j7c8bN7yu8WbF2Gm whk0RbSUFmoXMyWVsgrNKfa/dl5QMspbL6s5Kkm3/krABWSVsriITwHgW9jZqQ86+VIK+z R/Kn7PclBbMnnJUJrp7GCnKVSrVBnvQCb8V0GwfnQpaSDu/LWmjwKAgAzMRwJWFsGqq7Pu XHCAoCeHzsem87O6fJNv0YtIo1NRWcRTZczAShTIAiB/ZnF43HLZOaSzBkI3BA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774808661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gx5k1ECfOhsBlN1RAQ4RTscU4XLAoi7r+aBBfBVOqvs=; b=rWAsNf6JxMY65Iey5urIhW27hBm+dLJgHX0A1LtLLAsI8zgtuk3ZFfRWVnDACbl/ekZE13 9WK+y8hV9n1x7YLikaIlembrWyw8K6sNS/iZhfdd9o67gcSXdV/LJjK5Ape3y9K12H0zbg wlZJoxt4kIoNB4yFCos1Bf+2zd42R/jnnNG9HW34BvBohi4KIqZASNEvo76zeWaNuXVDRT Fxq8bUl7Zje0T7M9SO3m5EIt0RUpzZxCLJ6hszZEsUJmK8Oo/7FA29ObGJqcBfq9nobboN SaC5Gd/dkdS3JPbGqIBymgDh7CJo+IXFwpz/XoA803sLjTT2NaAtZwYVuhLOjg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fkN7n4hSnz1LlD for ; Sun, 29 Mar 2026 18:24:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 46cc4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 29 Mar 2026 18:24:21 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Salychev Subject: git: 968164eb650f - main - dpaa2: Perform bus_dma pre-write sync before enqueue operation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dsl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 968164eb650fd986f293512a3faac5c1c9e4d51f Auto-Submitted: auto-generated Date: Sun, 29 Mar 2026 18:24:21 +0000 Message-Id: <69c96e55.46cc4.256839da@gitrepo.freebsd.org> The branch main has been updated by dsl: URL: https://cgit.FreeBSD.org/src/commit/?id=968164eb650fd986f293512a3faac5c1c9e4d51f commit 968164eb650fd986f293512a3faac5c1c9e4d51f Author: Dmitry Salychev AuthorDate: 2026-03-28 18:57:45 +0000 Commit: Dmitry Salychev CommitDate: 2026-03-29 18:23:51 +0000 dpaa2: Perform bus_dma pre-write sync before enqueue operation Without a proper synchronization payload of the egress TCP segments can be corrupted as tuexen@ described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292006#c31. This patch is indirectly related to 292006 because a properly enabled and announced support for the TX checksum offloading hides potentially corrupted frame payload. PR: 292006 Reported by: tuexen@ Reviewed by: ... Tested by: dsl@ Differential Revision: MFC after: 3 days --- sys/dev/dpaa2/dpaa2_ni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/dpaa2/dpaa2_ni.c b/sys/dev/dpaa2/dpaa2_ni.c index c72e68b8a62f..49e72c8ee14f 100644 --- a/sys/dev/dpaa2/dpaa2_ni.c +++ b/sys/dev/dpaa2/dpaa2_ni.c @@ -3004,6 +3004,9 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, goto err_unload; } + bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); + bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); + /* TODO: Enqueue several frames in a single command */ for (int i = 0; i < DPAA2_NI_ENQUEUE_RETRIES; i++) { /* TODO: Return error codes instead of # of frames */ @@ -3013,9 +3016,6 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, } } - bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); - bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); - if (rc != 1) { fq->chan->tx_dropped++; if_inc_counter(sc->ifp, IFCOUNTER_OERRORS, 1);