From owner-freebsd-ports@freebsd.org Wed Mar 16 21:54:49 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DFD5AD3007 for ; Wed, 16 Mar 2016 21:54:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6E6CB1A23 for ; Wed, 16 Mar 2016 21:54:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6DC1BAD3006; Wed, 16 Mar 2016 21:54:49 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D63EAD3004 for ; Wed, 16 Mar 2016 21:54:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C4331A22 for ; Wed, 16 Mar 2016 21:54:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u2GLsgGI039458 for ; Wed, 16 Mar 2016 14:54:46 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201603162154.u2GLsgGI039458@gw.catspoiler.org> Date: Wed, 16 Mar 2016 14:54:42 -0700 (PDT) From: Don Lewis Subject: _STAGE_SEQ ordering (was: gnome-post-install ordering) To: ports@FreeBSD.org In-Reply-To: <201603161757.u2GHvsbJ038871@gw.catspoiler.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 21:54:49 -0000 Now that the ports framework has been totally converted to staging, I don't think the order of targets in _STAGE_SEQ is optimal. The current ordering is: 100:stage-dir 150:run-depends 151:lib-depends 200:apply-slist 300:pre-install 400:generate-plist 450:pre-su-install 475:create-users-groups 500:do-install 550:kmod-post-install 700:post-install 750:post-install-script 800:post-stage 850:compress-man 860:install-rc-script 870:install-ldconfig-file 900:add-plist-info 910:add-plist-docs 920:add-plist-examples 930:add-plist-data 940:add-plist-post When generating a dynamic plist, it would be handy to be able to just override generate-plist (or have a knob that causes the default target to dynamically generate the plist), but this has to be done after do-install. Some ports dynamically generate their plist at the end of their do-install target, but that will break if they add any do-install option helpers. Other ports generate their plist in in their post-install target, but that causes problems for targets that expect to parse the plist before post-install, such as 690:gnome-post-install). Since create-users-groups no longer creates the users and groups, but just generates a script to do so that gets packaged and or adds stuff to the plist, I don't think it needs to precede do-install, and moving later reduces the possibility that a dynamically generated plist created by do-install will stomp on what this target adds to the plist. The pre-su-install is probably less necessary now due to staging, but some ports use it so it would need to be retained and has to stay ahead of do-install. Something like the following looks better to me: 375:pre-su-install 400:do-install 500:generate-plist 525:create-users-groups This looks compatible with other users of _USES_install except for 600:webplugin-post-install, which should be moved earlier in the sequence, between 400 and 500. The cran:auto-plist knob could use a generic auto-plist knob instead of its own 750:cran-auto-plist.