Date: Tue, 5 Dec 2006 10:38:42 -0600 From: "Scot Hetzel" <swhetzel@gmail.com> To: "Wesley Shields" <wxs@atarininja.org> Cc: ports@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: distfile belongs to? Message-ID: <790a9fff0612050838s66c655fapfde80d4038f64ca2@mail.gmail.com> In-Reply-To: <20061204232125.GA42307@atarininja.org> References: <17771.24717.95357.989644@jerusalem.litteratus.org> <456B70E9.4030408@FreeBSD.org> <20061204213106.GA42084@atarininja.org> <45749998.3070308@FreeBSD.org> <20061204232125.GA42307@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/4/06, Wesley Shields <wxs@atarininja.org> wrote:
> > After a cursory exam this looks really great! I'd love to see this, or
> > something like it added ASAP. At minimum the bsd.port.mk patch should
> > definitely be added even if it takes a while for the other stuff to
> > percolate.
> >
> > Doug
>
> I'm fairly certain that the bsd.port.mk patch requires the other one
> (pkg_create will fall over when it encounters the @distfile lines). I'd
> be happy to send-pr it if nobody objects in a day or two.
>
The bsd.port.mk patch could be changed to:
.if (${OSVERSION} > 602100 && ${OSVERSION} < 700000) || ${OSVERSION} > 700027
PKGDISTFILE= "comment distfile"
.else
PKGDISTFILE="distfile"
.endif
:
:
- ${ECHO_CMD} "@distfle $${file}" >> ${TMPPLIST}; \
+ ${ECHO_CMD} "@${PKGDISTFILE} $${file}" >> ${TMPPLIST}; \
This would allow the bsd.port.mk patch be added, without having to
update the pkg_install tools on older systems.
Then the ports tools (portupgrade, portmaster, ..) could be changed to
look for either "@distfile" or "@comment distfile" in the +CONTENTS
file.
I also noticed that the patch to the pkg_info man page is using a
lower case f, instead of an upper case F for the option to show the
distfiles of a given package.
Scot
--
DISCLAIMER:
No electrons were mamed while sending this message. Only slightly bruised.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?790a9fff0612050838s66c655fapfde80d4038f64ca2>