From owner-freebsd-multimedia@FreeBSD.ORG Mon Mar 7 02:59:57 2005 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 987E116A4CE for ; Mon, 7 Mar 2005 02:59:57 +0000 (GMT) Received: from ns.kt-is.co.kr (ns.kt-is.co.kr [211.218.149.125]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B93643D39 for ; Mon, 7 Mar 2005 02:59:57 +0000 (GMT) (envelope-from yongari@kt-is.co.kr) Received: from michelle.kt-is.co.kr (ns2.kt-is.co.kr [220.76.118.193]) (authenticated bits=128) by ns.kt-is.co.kr (8.12.10/8.12.10) with ESMTP id j272tqAh001980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 7 Mar 2005 11:56:06 +0900 (KST) Received: from michelle.kt-is.co.kr (localhost.kt-is.co.kr [127.0.0.1]) by michelle.kt-is.co.kr (8.13.1/8.13.1) with ESMTP id j272xYOS001060 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 7 Mar 2005 11:59:34 +0900 (KST) (envelope-from yongari@kt-is.co.kr) Received: (from yongari@localhost) by michelle.kt-is.co.kr (8.13.1/8.13.1/Submit) id j272xRQ0001059; Mon, 7 Mar 2005 11:59:27 +0900 (KST) (envelope-from yongari@kt-is.co.kr) Date: Mon, 7 Mar 2005 11:59:27 +0900 From: Pyun YongHyeon To: Alexander Leidinger Message-ID: <20050307025927.GB951@kt-is.co.kr> References: <20050305224005.GC4237@cnd.mcgill.ca> <20050306162811.694d9c82@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050306162811.694d9c82@Magellan.Leidinger.net> User-Agent: Mutt/1.4.2.1i X-Filter-Version: 1.11a (ns.kt-is.co.kr) cc: freebsd-multimedia@freebsd.org cc: Mathew Kanner Subject: Re: uaudio patch, configurable buffer size X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: yongari@kt-is.co.kr List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2005 02:59:57 -0000 On Sun, Mar 06, 2005 at 04:28:11PM +0100, Alexander Leidinger wrote: > On Sat, 5 Mar 2005 17:40:05 -0500 > Mathew Kanner wrote: > > > Hi All, > > I couldn't use my usb device because the default buffer size > > (16*1024 bytes) was too much to be allocated (dma changes that > > happened a while ago). The following is a patch to make it a tunable: > > > > http://www.cnd.mcgill.ca/~mat/uaudio-HEAD-buffersize-tunable.diff.gz > > There's an open PR about it. It changes the buffer size. AFAIR it also > talks about changing the value of a parameter to a busdma call instead. > I've patched the busdma call and now the device is detected here (but I > don't hear any output...). > > I think you should add another set of validation code: The buffer size > is divided by 2 in the code, so I think it should at least print a > warning if "buffsize % 2 != 0". > AFAIK no. The buffer size should be power of 2. See pcm_getbuffersize() in sound.c. -- Regards, Pyun YongHyeon http://www.kr.freebsd.org/~yongari | yongari@freebsd.org