From owner-cvs-all@FreeBSD.ORG Thu Sep 15 18:59:36 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDFBE16A41F; Thu, 15 Sep 2005 18:59:36 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D95C43D46; Thu, 15 Sep 2005 18:59:35 +0000 (GMT) (envelope-from ru@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8FIxYna007640; Thu, 15 Sep 2005 18:59:35 GMT (envelope-from ru@repoman.freebsd.org) Received: (from ru@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8FIxY6v007639; Thu, 15 Sep 2005 18:59:34 GMT (envelope-from ru) Message-Id: <200509151859.j8FIxY6v007639@repoman.freebsd.org> From: Ruslan Ermilov Date: Thu, 15 Sep 2005 18:59:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/re if_re.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2005 18:59:37 -0000 ru 2005-09-15 18:59:34 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: re_detach() fixes: - Fixed if_free() logic screw-up that can either result in freeing a NULL pointer or leaking "struct ifnet". - Move if_free() after re_stop(); the latter accesses "struct ifnet". This bug was masked by a previous bug. - Restore the fix for a panic on detach caused by racing with BPF detach code by Bill by moving ether_ifdetach() after re_stop() and resetting IFF_UP; this got screwed up in revs. 1.30 and 1.36. Revision Changes Path 1.52 +7 -15 src/sys/dev/re/if_re.c