From owner-svn-src-head@FreeBSD.ORG Tue Jan 14 20:37:21 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 09C48534 for ; Tue, 14 Jan 2014 20:37:21 +0000 (UTC) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9162C1687 for ; Tue, 14 Jan 2014 20:37:20 +0000 (UTC) Received: by mail-wi0-f172.google.com with SMTP id ex4so2437289wid.11 for ; Tue, 14 Jan 2014 12:37:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=mY8lvjZuUWppvLeus932K0w7eXIAYlXy8XV+cfAXKBE=; b=kXMp52jkCTMxjiRyWGMaNui6xIP42jYzMskurBfToJ13bw68nsXMyp9mkfg/93RKZI Od0OJdzrl4ayD4mKKoP704LKlxAbo3SKm+ntroL2aFy3VczVLcOGJ5h8CxMacPAiL97K 4nUzCnx1nLLrhyooi3STgsiYnN3TLI27ZX7yaeKO0mE50mq7MzvmpOjyiyMN3ub6axZS 7jQ30hcRGv9ehmzGXhIgu8g9q7REbeaEozvROONHHp3US0fAl8vkafqVWHLT0fWaWp0l 6Mgiwru38f+W0OC+t4RYLgkouuXyZhGtL6OYVui73hiEdg/qBU3z1vbQm7pY2PDgaqBi XBTg== X-Gm-Message-State: ALoCoQkGnfLz5b3BI66+8wSt2+zySnWq63ESUfGp/RNVxsb+suY4SaRhQrIOx4Vs8qxyb2XQioWL X-Received: by 10.194.82.105 with SMTP id h9mr375628wjy.52.1389731344231; Tue, 14 Jan 2014 12:29:04 -0800 (PST) Received: from [192.168.1.118] (62.57.0.127.dyn.user.ono.com. [62.57.0.127]) by mx.google.com with ESMTPSA id ks3sm1492182wjc.10.2014.01.14.12.28.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jan 2014 12:28:59 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r260586 - head/bin/pax/tests From: Julio Merino In-Reply-To: <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net> Date: Tue, 14 Jan 2014 21:28:55 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201401131217.s0DCHflD060494@svn.freebsd.org> <20140113135930.GR97375@ithaqua.etoilebsd.net> <01D805C2-AB9D-48F5-A972-FC7E801DC21E@meroh.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.1827) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 20:37:21 -0000 On Jan 13, 2014, at 15:34, Julio Merino wrote: > On Jan 13, 2014, at 14:59, Baptiste Daroussin = wrote: >=20 >> On Mon, Jan 13, 2014 at 12:17:41PM +0000, Julio Merino wrote: >>> +tap_test_program{name=3D"legacy_test", = required_programs=3D"/usr/bin/perl"} >>=20 >> Shouldn't that be /usr/local/bin/perl or ${LOCALBASE}/bin/perl, we = are trying >> hard on ports to remove by default /usr/bin/perl which is a legacy = from the >> removal of perl from base. >=20 > Only if legacy_test.sh is also modified to use /usr/local/bin/perl. = (I don't think using LOCALBASE is possible given that it's not = accessible from share/mk/.) >=20 > If it's the right thing to do, I can change it. FTR, I did this change as part of some other generalizations and = cleanups. Test programs that use the new TAP_TESTS_PERL feature of = tap.test.mk should get the right path to the perl interpreter.=