From owner-svn-src-all@freebsd.org Fri Dec 13 21:41:27 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 595D31D801E; Fri, 13 Dec 2019 21:41:27 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ZPHq1TBsz4YbT; Fri, 13 Dec 2019 21:41:27 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [172.17.133.228] (unknown [12.202.168.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 822E22475; Fri, 13 Dec 2019 21:41:26 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.20.0.191208 Date: Fri, 13 Dec 2019 13:41:21 -0800 Subject: Re: svn commit: r355735 - in head/sys: arm/broadcom/bcm2835 arm/mv dev/ow From: Ravi Pokala To: Warner Losh , , , Message-ID: Thread-Topic: svn commit: r355735 - in head/sys: arm/broadcom/bcm2835 arm/mv dev/ow References: <201912132139.xBDLdK99042422@repo.freebsd.org> In-Reply-To: <201912132139.xBDLdK99042422@repo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Dec 2019 21:41:27 -0000 Thanks! -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Warner Losh Date: 2019-12-13, Friday at 13:39 To: , , Subject: svn commit: r355735 - in head/sys: arm/broadcom/bcm2835 arm/mv dev= /ow Author: imp Date: Fri Dec 13 21:39:20 2019 New Revision: 355735 URL: https://svnweb.freebsd.org/changeset/base/355735 =20 Log: Be consistent about checking return value from bus_delayed_attach_chi= ldren. =20 Most places checked, but a couple last minute changes didn't. Make th= em all use the return value. =20 Noticed by: rpokala@ =20 Modified: head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c head/sys/arm/mv/a37x0_spi.c head/sys/dev/ow/owc_gpiobus.c =20 Modified: head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D --- head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c Fri Dec 13 21:39:10 201= 9 (r355734) +++ head/sys/arm/broadcom/bcm2835/bcm2835_bsc.c Fri Dec 13 21:39:20 201= 9 (r355735) @@ -347,9 +347,7 @@ bcm_bsc_attach(device_t dev) } =20 /* Probe and attach the iicbus when interrupts are available. */ - bus_delayed_attach_children(dev); - - return (0); + return (bus_delayed_attach_children(dev)); } =20 static int =20 Modified: head/sys/arm/mv/a37x0_spi.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D --- head/sys/arm/mv/a37x0_spi.c Fri Dec 13 21:39:10 2019 (r355734) +++ head/sys/arm/mv/a37x0_spi.c Fri Dec 13 21:39:20 2019 (r355735) @@ -220,9 +220,7 @@ a37x0_spi_attach(device_t dev) device_add_child(dev, "spibus", -1); =20 /* Probe and attach the spibus when interrupts are available. */ - bus_delayed_attach_children(dev); - - return (0); + return (bus_delayed_attach_children(dev)); } =20 static int =20 Modified: head/sys/dev/ow/owc_gpiobus.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D --- head/sys/dev/ow/owc_gpiobus.c Fri Dec 13 21:39:10 2019 (r355734) +++ head/sys/dev/ow/owc_gpiobus.c Fri Dec 13 21:39:20 2019 (r355735) @@ -131,9 +131,7 @@ owc_gpiobus_attach(device_t dev) free(kids, M_TEMP); if (nkid =3D=3D 0) device_add_child(dev, "ow", -1); - bus_delayed_attach_children(dev); - - return (0); + return (bus_delayed_attach_children(dev)); } =20 static int =20