From owner-cvs-all Fri Jul 12 9:28:35 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0F9C437B400; Fri, 12 Jul 2002 09:28:32 -0700 (PDT) Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E07243E65; Fri, 12 Jul 2002 09:28:31 -0700 (PDT) (envelope-from dl@catspoiler.org) Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g6CGS3wr014471; Fri, 12 Jul 2002 09:28:07 -0700 (PDT) (envelope-from dl@catspoiler.org) Message-Id: <200207121628.g6CGS3wr014471@gw.catspoiler.org> Date: Fri, 12 Jul 2002 09:28:03 -0700 (PDT) From: Don Lewis Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c To: imp@bsdimp.com Cc: hsu@FreeBSD.org, truckman@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <20020712.101645.125311016.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12 Jul, M. Warner Losh wrote: > In message: <0GZ4004U3MZCIJ@mta5.snfc21.pbi.net> > Jeffrey Hsu writes: > : > Lock inp while we're accessing it. > : > : Here's a rhetorical question: why? That inp was purposely left unlocked. > > I can only assume that he didn't have enough: > > ../../../vm/uma_core.c:1332: could sleep with "inp" locked from ../../../netinet/tcp_usrreq.c:536 > > messages in his dmesg log. I checked in a fix for that violation last night. SYSCTL_OUT() can block, so calling it with a lock held will cause this error. This particular case was easy to fix by moving the call to SYSCTL_OUT() outside the locked region. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message