From owner-svn-ports-all@FreeBSD.ORG  Sat Jan 26 16:27:19 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 8A5A1452;
 Sat, 26 Jan 2013 16:27:19 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 by mx1.freebsd.org (Postfix) with ESMTP id 41E006D2;
 Sat, 26 Jan 2013 16:27:18 +0000 (UTC)
Received: from [192.168.192.192] (d24-156-192-11.home4.cgocable.net
 [24.156.192.11]) (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 3A9FC11F933;
 Sat, 26 Jan 2013 11:27:09 -0500 (EST)
References: <201301261106.r0QB61l8070374@svn.freebsd.org>
 <CAMuy=+gw=BaoZQ2_7nhVX7OBk=Lv29ym4McziuVCVhOiWwsizA@mail.gmail.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <CAMuy=+gw=BaoZQ2_7nhVX7OBk=Lv29ym4McziuVCVhOiWwsizA@mail.gmail.com>
Message-Id: <E0FDED6D-4F1F-408E-95A7-B313BFF983EA@adamw.org>
X-Mailer: iPad Mail (10A523)
From: Adam Weinberger <adamw@adamw.org>
Subject: Re: svn commit: r311004 - head/devel/rbenv
Date: Sat, 26 Jan 2013 11:27:08 -0500
To: Jason Helfman <jgh@FreeBSD.org>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Marcus von Appen <mva@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jan 2013 16:27:19 -0000



On 2013-01-26, at 10:18, Jason Helfman <jgh@FreeBSD.org> wrote:

> On Sat, Jan 26, 2013 at 3:06 AM, Marcus von Appen <mva@freebsd.org> wrote:=

>> +%%DATADIR%%/completions/rbenv.bash
>> +%%DATADIR%%/completions/rbenv.zsh
>> +@dirrm %%DATADIR%%/completions
>> +@dirrm %%DATADIR%%
>=20
> IMHO shouldn't completions be tied into the OPTIONS framework and be condi=
tional installed as other ports?
>=20
> -jgh

This port doesn't install completions in the bash or zsh completion bundle d=
irs. it installs it in its own DATADIR, leaving it up to the user to copy or=
 symlink to it from the proper location. We don't need an OPTION for everyth=
ing under the sun.

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org=