From owner-svn-ports-head@freebsd.org Thu Oct 25 13:15:52 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6B7E1075B54; Thu, 25 Oct 2018 13:15:52 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CE6081797; Thu, 25 Oct 2018 13:15:52 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 5CCAD1473E; Thu, 25 Oct 2018 13:15:51 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Thu, 25 Oct 2018 15:15:49 +0200 From: Mathieu Arnold To: Mateusz Piotrowski <0mp@freebsd.org> Cc: mat@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r482963 - head/misc/exercism Message-ID: <20181025131549.i4r2g26nyfuiztdz@ogg.in.absolight.net> References: <201810250948.w9P9mGSb099015@repo.freebsd.org> <20181025115917.z2h6zx5txmxkzrtj@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lum45gota2byj56j" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 13:15:52 -0000 --lum45gota2byj56j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 25, 2018 at 03:03:43PM +0200, Mateusz Piotrowski wrote: > Hi, >=20 > On Thu, 25 Oct 2018 at 13:59, Mathieu Arnold wrote: >=20 > > On Thu, Oct 25, 2018 at 09:48:16AM +0000, Mateusz Piotrowski wrote: > > > - Use DISTVERSION instead of PORTVERSION as suggested by the handbo= ok. > > > > This should not have happened, the version did not change. > > >=20 > Hmmm, could you please tell me more about this? I thought that > it is just a style change because the final value of PORTVERSION > has not changed. Because it changes nothing, and adds useless churn to the repository. >=20 > > > - Move GH_TUPLE out of the USE* section. > > > > This is wrong, see: > > > > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-use= s.html >=20 >=20 > Thank you for pointing this out. > https://reviews.freebsd.org/D17699 >=20 > Thanks, Mathieu! > Mateusz --=20 Mathieu Arnold --lum45gota2byj56j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvRwgRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgQ3w//QIAPGCMxibdJEfaM86EC2nX7SJR7Fk8MG8387rpXqVSPPnK+J24QIMM/ I37EXzFhbOL5QOALZ/7RBEWPlgUxZCjFOABbRRR0z7N+nlgkGiHmBW/ov8L4E0b4 h19UE1RV461HIPMcb/iKHZBQryeJJjRcGGQn1n5paTdlyCrNSVrYiSQCDe2DKH6n ekxAeFrOrBroxCt5u3p+wVHnMvnfYXnsFY9g2NgY1QjEs4HRTn0/VnQklA8ZrBN9 iJnUpV+pcQ1GZcTG/1hCOC2UOH+706n8I5Zr1Pg9QtNzf8/zE6w2GndyeTvXsz3b rK6CqP9GLsz7h9/SVcmaqUiIcXZXOU1aRdXCh4fwSWD8wPdiuC39dWBuIaUE2G8e rvH/u+I5pEkl06m+LbeKRMHJiPvgvxFSDqEPLgYs4dnnDIbbDxg0gpdh2NRTxL/M mSU0duCEOPwjY5ulczhigywloUSAqy9HCIZdYvKHB9WG/GTwo59U77YjgfxtD3GK 67fAfq0ipIGQNZcaA+/DWNbUQ2JUk6FWDUio+S7VniBgP3utqUtFaZrEtM8LpxUQ 4DowkQRPvHXd853/vxBX0rUxxSXawTU9Qg/aXQgHX4oFWjZWB5b/s56H/Vyww2oy aYXhIiGaLxJu3MgcjOdV3IEjvvhprL7QO7XUK2Phz2UXIOGPfEY= =DHUJ -----END PGP SIGNATURE----- --lum45gota2byj56j--