Date: Fri, 7 Dec 2012 09:39:34 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Cy Schubert <Cy.Schubert@komquats.com> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org, Cy Schubert <cy@FreeBSD.org> Subject: Re: svn commit: r308201 - head/mail/exmh2 Message-ID: <20121207083934.GF11579@gahrfit.gahr.ch> In-Reply-To: <201212070613.qB76DU19017522@slippy.cwsent.com> References: <Cy.Schubert@komquats.com> <201212050758.qB57wwjg005243@slippy.cwsent.com> <201212070613.qB76DU19017522@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Wb5NtZlyOqqy58h0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Dec-06, 22:13, Cy Schubert wrote: > In message <201212050758.qB57wwjg005243@slippy.cwsent.com>, Cy Schubert= =20 > writes: > > In message <20121204114110.GC5906@gahrfit.gahr.ch>, Pietro Cerutti writ= es: > > >=20 > > > --1SQmhf2mF2YjsYvc > > > Content-Type: text/plain; charset=3Dutf-8 > > > Content-Disposition: inline > > > Content-Transfer-Encoding: quoted-printable > > >=20 > > > On 2012-Dec-04, 06:21, Cy Schubert wrote: > > > > Author: cy > > > > Date: Tue Dec 4 06:21:05 2012 > > > > New Revision: 308201 > > > > URL: http://svnweb.freebsd.org/changeset/ports/308201 > > > >=3D20 > > > > Log: > > > > Use TCL/Tk 8.6. This fixes issues with the mail messages list "Mo= re..." > > > > button. > > > > =3D20 > > > > Assume care and feeding of this port. > > > > =3D20 > > > > Feature safe: yes > > > >=3D20 > > > > Modified: > > > > head/mail/exmh2/Makefile > > > >=3D20 > > > > Modified: head/mail/exmh2/Makefile > > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D > > > > --- head/mail/exmh2/Makefile Tue Dec 4 06:18:16 2012 (r30820 > > > 0) > > > > +++ head/mail/exmh2/Makefile Tue Dec 4 06:21:05 2012 (r30820 > > > 1) > > > > @@ -14,7 +14,7 @@ CATEGORIES+=3D3D mail tk > > > > MASTER_SITES=3D3D ${MASTER_SITE_TCLTK} \ > > > > SF > > > > =3D20 > > > > -MAINTAINER?=3D3D ports@FreeBSD.org > > > > +MAINTAINER?=3D3D cy@FreeBSD.org > > > > COMMENT?=3D3D X11/TK based mail reader front end to MH > > > > =3D20 > > > > .if defined(JAPANESE_EXMH) > > > > @@ -23,10 +23,10 @@ BUILD_DEPENDS=3D3D tclsh8.0jp:${PORTSDIR}/ja > > > > WISH=3D3D wish8.0jp > > > > TCLSH=3D3D tclsh8.0jp > > > > .else > > > > -RUN_DEPENDS=3D3D wish8.5:${PORTSDIR}/x11-toolkits/tk85 > > > > -BUILD_DEPENDS=3D3D tclsh8.5:${PORTSDIR}/lang/tcl85 > > > > -WISH=3D3D wish8.5 > > > > -TCLSH=3D3D tclsh8.5 > > > > +RUN_DEPENDS=3D3D wish8.6:${PORTSDIR}/x11-toolkits/tk86 > > > > +BUILD_DEPENDS=3D3D tclsh8.6:${PORTSDIR}/lang/tcl86 > > > > +WISH=3D3D wish8.6 > > > > +TCLSH=3D3D tclsh8.6 > > > > .endif > > >=20 > > > Might I suggest the following patch here? > > >=20 > > > =3D3D=3D3D BEGIN PATCH =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > > Index: Makefile > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D > > > --- Makefile (revision 308234) > > > +++ Makefile (working copy) > > > @@ -23,10 +23,7 @@ > > > WISH=3D3D wish8.0jp > > > TCLSH=3D3D tclsh8.0jp > > > .else > > > -RUN_DEPENDS=3D3D wish8.6:${PORTSDIR}/x11-toolkits/tk86 > > > -BUILD_DEPENDS=3D3D tclsh8.6:${PORTSDIR}/lang/tcl86 > > > -WISH=3D3D wish8.6 > > > -TCLSH=3D3D tclsh8.6 > > > +USE_TK=3D3D 86 > > > .endif > > > =3D20 > > > # exmh is pretty useless without this, but it's not needed to build = it. > > > @@ -55,7 +52,7 @@ > > > =3D20 > > > do-build: > > > @cd ${WRKSRC} && ${SETENV} PREFIX=3D3D${PREFIX} TCLSH=3D3D${TCLSH} \ > > > - WISH=3D3D${PREFIX}/bin/${WISH} WRKSRC=3D3D${WRKSRC} \ > > > + WISH=3D3D${WISH} WRKSRC=3D3D${WRKSRC} \ > > > ${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/build > > > =3D20 > > > do-install: > > > =3D3D=3D3D END PATCH =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D= 3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3= D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > =3D > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D > > >=20 > > > Moreover, I've seen that 2.8.0 is out. It's buildable as long as you > > >=20 > > > D files/patch-lib-folder.tcl > > > D files/patch-lib-quote.tcl > > > D files/patch-lib-uri.tcl > > >=20 > > > Unfortunately I'm not familiar enough with the interface to properly > > > run-test it. > >=20 > > Cool, thanks. I'll commit the first suggestion as soon as I get a chanc= e.=20 > > And, I'll look into 2.8.0 when I get some free time. >=20 > I've managed to install 2.8.0 (using it now). However USE_TK=3D86 results= in=20 > script invocation lines to set as /usr/local//usr/local/bin/tk8.6. I'm=20 > thinking of committing 2.8.0, then find the time to resolve the USE_TK=20 > issue later. Isn't this fixed by the part of my patch around lines 55 and following? --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --Wb5NtZlyOqqy58h0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDBq0UACgkQwMJqmJVx945dyACgyXUwkN7gtnQg9DZbO4oc5wr7 yyQAn2AbaJrgbKiTWOxxX2cvvqdUgQkZ =gfhg -----END PGP SIGNATURE----- --Wb5NtZlyOqqy58h0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121207083934.GF11579>