From owner-freebsd-ports-bugs@freebsd.org Sat Jul 9 08:38:45 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90F2EB84649 for ; Sat, 9 Jul 2016 08:38:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F51918DE for ; Sat, 9 Jul 2016 08:38:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u698cjfP070944 for ; Sat, 9 Jul 2016 08:38:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 210937] devel/gmake: make-4.2.1/strcache.c's strcache_print_stats(. . .) uses %hu for an int value Date: Sat, 09 Jul 2016 08:38:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markmi@dsl-only.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tijl@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2016 08:38:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210937 Bug ID: 210937 Summary: devel/gmake: make-4.2.1/strcache.c's strcache_print_stats(. . .) uses %hu for an int value Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: tijl@FreeBSD.org Reporter: markmi@dsl-only.net Flags: maintainer-feedback?(tijl@FreeBSD.org) Assignee: tijl@FreeBSD.org make-4.2.1/strcache.c has code in strcache_print_stats(. . .) that looks li= ke: printf (_("%s current buf: size =3D %hu B / used =3D %hu B / count =3D %h= u / avg =3D %hu B\n"), prefix, (sc_buflen_t)BUFSIZE, strcache->end, strcache->count, (strcache->end / strcache->count)); but (strcache->end / strcache->count) has an int type, not the unsigned sho= rt type that the matching %hu format specifies. The argument in question is an int already without promotion and could potentially have a value that would be truncated by the format ignoring the most significant part of the int value --thus leading to the compiler compl= aint possibly not being a false positive for inaccurate/incomplete information b= eing printed. --=20 You are receiving this mail because: You are the assignee for the bug.=