From owner-svn-src-all@freebsd.org Thu Dec 22 23:32:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEDC9C8D4A1; Thu, 22 Dec 2016 23:32:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wj0-f195.google.com (mail-wj0-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E4901796; Thu, 22 Dec 2016 23:32:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wj0-f195.google.com with SMTP id kp2so38166459wjc.0; Thu, 22 Dec 2016 15:32:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=Z8PoypfFiMnhZtC6FASHCoCDRe+0tFYUNb61hXcp8ss=; b=F62VtFJB8bLMKdeJ62J0Y/FU9xHTUewyV4F2Ygkhxm0XxHq0OKkEQq2X9dJX8TquG9 1V+Vqru9VTTsHnc/LPHekHx6nj07lAOLwVrvzRHl5Sdp7UzsPhjYTMR5ujs57wwMZev5 deAe6T3fx+VksY8Sobbnnr4dVoeDi/P7egZ7xqac2OyxyDQNQroOwc/CWdi+mfnZ+q/l xWKGBy0Gpz1BAqZqK+zpsuQmN1TR4exQMFajYERs1K9DzTpTbI/tairn7qj62/gRBmBQ xktY55o/DJ79inIqt3nEVa3FjTwnpWd5tCvz/p56bojlZvEMKGZGgGJjRwnwOiPsXxqY WMQg== X-Gm-Message-State: AIkVDXLV/nU69LU/3r4mkqQn0A0yp/WWzBNWWukAq9fx8ylzRYS5KdZF+89o+oAzDEZo2A== X-Received: by 10.194.141.98 with SMTP id rn2mr10983970wjb.1.1482449542383; Thu, 22 Dec 2016 15:32:22 -0800 (PST) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com. [74.125.82.41]) by smtp.gmail.com with ESMTPSA id k11sm34230552wmf.24.2016.12.22.15.32.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 15:32:22 -0800 (PST) Received: by mail-wm0-f41.google.com with SMTP id k184so3090838wme.1; Thu, 22 Dec 2016 15:32:22 -0800 (PST) X-Received: by 10.28.88.11 with SMTP id m11mr13039997wmb.45.1482449542026; Thu, 22 Dec 2016 15:32:22 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Thu, 22 Dec 2016 15:32:21 -0800 (PST) In-Reply-To: References: <201612222230.uBMMUge9075128@repo.freebsd.org> From: Conrad Meyer Date: Thu, 22 Dec 2016 15:32:21 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r310433 - head/lib/libc/stdio To: "Ngie Cooper (yaneurabeya)" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 23:32:25 -0000 On Thu, Dec 22, 2016 at 3:16 PM, Ngie Cooper (yaneurabeya) wrote: > > On Dec 22, 2016, at 2:39 PM, Conrad Meyer wrote: > > This was unjustified and inappropriate. > > > Conrad, > > From the committer=E2=80=99s guide ( > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/art= icle.html#developer.relations > ): > > If you are unsure about a commit for any reason at all, have it reviewed = by > -hackers before committing. Better to have it flamed then and there rathe= r > than when it is part of the repository. If you do happen to commit someth= ing > which results in controversy erupting, you may also wish to consider back= ing > the change out again until the matter is settled. Remember =E2=80=93 with= a version > control system we can always change it back. > > Per the commit message, the change wasn=E2=80=99t reviewed before commit = (" Reviewed > by: no one, unfortunately=E2=80=9D). More than a handful of people reques= ted that > the commit be reverted/changed. There wasn=E2=80=99t an issue with the co= ntent > created =E2=80=94 there was just an issue with how %b was implemented (es= pecially > when it impedes being able to cross-compile FreeBSD on other operating > systems or port code to those operating systems). > Dmitriy=E2=80=99s comment about adding snprintb(3) from NetBSD makes a lo= t of sense > and will reintroduce the code that you added here, and I fully agree and > support his suggestion. > For what it=E2=80=99s worth from personal experience, it=E2=80=99s really= a pain when > non-standard things get leaked into FreeBSD, or when you have to port > software to other operating systems that use non-standard interfaces (I > usually have to do this moving Linux code to FreeBSD). Take the format > -fformat* string functionality in OneFS =E2=80=94 it=E2=80=99s unfortunat= e that we can=E2=80=99t use > a standard compiler to compile OneFS out of the box and instead have to > bootstrap a compiler which is intelligent enough to understand how the > custom format strings work, just to compile user space/a kernel. > Thank you, > -Ngie Ngie, The revert was unjustified and inappropriate, period. You haven't justified it here either. The guide refers to reverting your own commits, not others'. Please stop helping. Conrad