From owner-freebsd-current@FreeBSD.ORG Mon May 25 12:15:49 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC4AA106568C for ; Mon, 25 May 2009 12:15:49 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-fx0-f168.google.com (mail-fx0-f168.google.com [209.85.220.168]) by mx1.freebsd.org (Postfix) with ESMTP id 5CF738FC15 for ; Mon, 25 May 2009 12:15:48 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by fxm12 with SMTP id 12so3183130fxm.43 for ; Mon, 25 May 2009 05:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=K0amrihgDNw/SG4UzPreDAdP3IiOl6tat49+09idr6Y=; b=Cy+UYaBCC908Nhf61NkGBv1pD9ofH40To8aewove50vGYGg+Md32wOStbL38vpJWZm zFFpM0gSXAcbJk0v1x+3q5R3oAYj12+0gZ4+AO6HZCALdxHy5PQfyMjpR3/26f5eWwrE vDxZLzXYGT2PtP0J24oWCn4rWcb/pu35RQbIs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=TVKXS0e53EBSpsa/GkHxW0YbpMxfF/9DEBxSsqF0zACR6qdZRrv8L1KChNfMLZIcdO IHyDNxtxdFN7q48oaHfVuxcJaJMqn/Via4Fu+/2ayb8gNIvDy+4PRwDmmjPTyKJSKURB SlrVR7Y20E4gdyLjBygKpAkw4nJQuCw+3sW7E= MIME-Version: 1.0 Received: by 10.204.53.143 with SMTP id m15mr6934673bkg.119.1243253748146; Mon, 25 May 2009 05:15:48 -0700 (PDT) In-Reply-To: <4A11A08B.6090309@errno.com> References: <4A11A08B.6090309@errno.com> Date: Mon, 25 May 2009 14:15:48 +0200 Message-ID: <3a142e750905250515i5e6a21b0qe6eee63973efa7b8@mail.gmail.com> From: "Paul B. Mahol" To: Sam Leffler Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: 802.11 monitor mode changes coming X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2009 12:15:51 -0000 On 5/18/09, Sam Leffler wrote: > The patch here: > > http://people.freebsd.org/~sam/monitor-20090518.patch > > has significant changes to monitor mode operation. Most importantly it > replaces DLT_IEEE802_11 support in net80211 by DLT_IEEE802_11_RADIO and > removes the latter from the underlying device. The upshot is that you > can no longer do: > > tcpdump -i ath0 > > instead you will now need a wlanX ifnet; e.g. > > ifconfig wlan create wlandev ath0 wlanmode monitor channel 6 up > tcpdump -i wlan0 -y IEEE802_11_RADIO > > This addresses the longstanding issue that applications like kismet that > want radiotap data needed to open two ifnets, one to receive data and > one to do channel changes. My main concern is whether losing > DLT_IEEE802_11 support will affect any apps. Those that depend on it > should be easy to change; you just request a different DLT and strip the > radiotap header from tap'd frames (or similar). > > In sweeping the drivers to do these changes I've made radiotap support > more consistent and improved some drivers. Drivers not tested so far: > malo, ipw, wpi, and upgt. I tested iwi and it appears broken in that no > frames are rx'd but I'm not sure I'll look at it before 8.0. > > I plan to commit these changes by the end of the week. It makes ndisulator panic, following stupid patch fix it for me: --- /sys/net80211/ieee80211_radiotap.c 2009-05-25 12:14:29.000000000 +0000 +++ ieee80211_radiotap.c 2009-05-25 12:13:59.000000000 +0000 @@ -102,6 +102,8 @@ struct ieee80211com *ic = vap->iv_ic; struct ieee80211_radiotap_header *th = ic->ic_th; + if (th == NULL) + return; KASSERT(th != NULL, ("no radiotap setup")); /* radiotap DLT for raw 802.11 frames */ -- Paul