From owner-cvs-usrsbin  Sat Apr  1 19:39:29 1995
Return-Path: cvs-usrsbin-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id TAA21401 for cvs-usrsbin-outgoing; Sat, 1 Apr 1995 19:39:29 -0800
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id TAA21336; Sat, 1 Apr 1995 19:37:48 -0800
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id NAA29929; Sun, 2 Apr 1995 13:36:18 +1000
Date: Sun, 2 Apr 1995 13:36:18 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199504020336.NAA29929@godzilla.zeta.org.au>
To: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com,
        wpaul@freefall.cdrom.com
Subject: Re: cvs commit: src/usr.sbin/ypbind ypbind.c
Sender: cvs-usrsbin-owner@freebsd.org
Precedence: bulk

>wpaul       95/04/01 19:10:58

>  Modified:    usr.sbin/ypbind ypbind.c
>  Log:
>  Fix long standing bogosity in ypbind: if /var/yp/binding doesn't exist,
>  ypbind is supposed to create it but it doesn't. This is because when
>  it checks the return value for the attempted open() of
>  /var/yp/binding/DOMAIN.VERSION, it tests only for a value of -1. This
>  is bogus because open() doesn't return -1 in this case. Now it checks
>  for < 0 instead.

open() is spec'ed to return -1 for errors.  When doesn't it?  It is also
spec'ed to return a non-negative integer so checking for < 0 is safer,
but I prefer -1 for consistency with syscalls like read().

Bruce