From nobody Sun Jul 12 15:43:42 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gyqcB6lD7z6lX8y for ; Sun, 12 Jul 2026 15:43:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gyqcB4Ldwz45XG for ; Sun, 12 Jul 2026 15:43:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-92e5c92c389so117510085a.3 for ; Sun, 12 Jul 2026 08:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783871033; cv=none; d=google.com; s=arc-20260327; b=sPD2HdzmINTknXrJpdZr/Icz7+H/50MAGhO895z7t8MV2Zxh6X9qKE0TSrChkc0TVG L9emJ7RjPW0phE4tfiFcFCO3Tn7+IwPLkvseut/dyKqOYPCEb1AX7zE7UJOiICiaqec+ gP/hOmbwASQMOQbHvJ3tVRkKy1AwcpMnrxjNbatQpE6QtfVgQBa5DqsqJgnJ29oPbrHA qV0LBEJ70FRT4evfQUcJup+2ac4BpvVJoLjH5ej8nIvL42ZAgE9weQgVRK310xWo+Hxo UwNWv7j7ABzX1vaMNprgfD6ICsLayoYLT/ZOKTlGIeu8we/v4Kn2rOr8nO0GKtjCqOQx d2Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=O3hyztXfUa7TAfry2nTzzCk/2Uhi6gdoxrh5qQqfmgY=; fh=9c0GOOltSmZkX46zbqCOdk6Mlx5Mzx8rPnt6umkzcNo=; b=XbhveOi08Fx9pkHhDI+kpygs2DZZPjpUhGQsiZLfaOlbslEJ5tm1XcHpBPuocwe4Jh IhLFi4GpmcDlp0U7jD18UWProI//jhF16bChIDnK7KbQUGrVuQdjyED+gwVvOgp0U9fG Xrbqdmc+rW5tPU2sxRX0THLfmdNBBjF0ZiiyI0BtcuKyoLB9R4tVyIwtjARAS/lg2cIj YiKhscN17MPyqyI2XG0jjF0enblSqcRmtQXwC50xeL9x4gaszGyHXXYRcQnXmEVmo4xX DgPuneaCs3N1ipKIMKbt6V6VCJCzjcF1YC5Hu4I+cic/ufnV1L7C/rsMiagwJGXGG+GA pzHg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783871033; x=1784475833; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=O3hyztXfUa7TAfry2nTzzCk/2Uhi6gdoxrh5qQqfmgY=; b=mQ3+GJ1SnjPT28bfNoS2pC7hVc1M0v8wB6b5i1jZP9gwb3rcVpy1owbtayt2Lq5TPi tHFTJg/9YcEaJ/V7DjGru1xyx6/KKKCbjRo+2oBDnq8WUxO6HkZXXcDVp9+OgRS99iu0 PaB/6q4pNXBHKj5InSPE0TEvIv+qMvROguKUXdQx3Bu9XhfkmtJGRYiSgWS5JZbtfbfV Xb9nmoldRUzEBK43BCbRKjJb2eavGbF4/4CcLX3UShwILVIA9V1FpyKN+RVyCfkTxOOZ b1GxPFsEeRCqWJIygT09r7Vm5TJGGGPeXZIukGFxR/bgZa+Iz/ZoH4ru/5ZsLrW+sBgK ecFw== X-Forwarded-Encrypted: i=1; AHgh+Rrsl+k5QkJhhbfJgv2049xxmgi9FuhJmSNs1LDlu39tUnsfjms7yKDN9tVOqZ0RHw7VDPVFEO7XDiNqyp6OgMVyp4PV6w==@freebsd.org X-Gm-Message-State: AOJu0Yy2oIGzT6CJTY+cLeMZqKHRkPUNFzcCgetaQdAe797wzfrbHe+D G1+gtOr60l7jUUKh7Xxo+iI80uCmkWXYjuvZqQmWfP8lvp1ellKLUk7iJjtXTk6BMb8cKbGOY/n v89WLdH+nyeFmPR95IY9zGvzAz4f7h94S3A== X-Gm-Gg: AfdE7ck4BCdNAWlHQlq1hVqZjjLEL6HBKgDDTgGfIgwrv/+9IfQKiM+0Aey8wjGuGk1 sado/nnDW1YIhXlhctWKEA0zVxRzccE6ROEh7wRm1DrdaqnYAYn62XzaRpMOjvYHzwfJWhau1po yfN1UI2qwK4rVXJ9i5Trs/eldR00kTCm06G2MAEg4btkLQqI4zMXmwi5qqT92Yc+Ip8QkNgekMf r+Fisxg5PigCOfFnCsvWhWJQJz49ftOI1NCSL4od2PnLHOgWRW0sbrStuBWrX3NDznN+FCCVqVT mc6Bl8trwpYhC+jN2AkrUKVOpwQxSHaBYd+RgubbOveW01yPMj2h1LdyRBe4fqAa3QATU1IOmOc sMhXrDpgmAD9gQOUvTQ3xsSWdxoggBR3K1CvSftA/3IhaZfw= X-Received: by 2002:a05:620a:608a:b0:92e:8405:7ae8 with SMTP id af79cd13be357-92ef2b3888emr592813685a.4.1783871033519; Sun, 12 Jul 2026 08:43:53 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a1008a0.3f79c.1d455f29@gitrepo.freebsd.org> <49761290-2d6c-403f-acdd-48b5b536804c@FreeBSD.org> In-Reply-To: <49761290-2d6c-403f-acdd-48b5b536804c@FreeBSD.org> From: Adrian Chadd Date: Sun, 12 Jul 2026 08:43:42 -0700 X-Gm-Features: AUfX_mxWciTEb_ANI7QFMI3kHQlcKZY31KWRMOVv_hof4xOKfZZl74aRc9-C5LE Message-ID: Subject: Re: git: 28d85db46b48 - main - xhci: Do not drop and add bits in xhci To: Kyle Evans Cc: ShengYi Hung , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Vladimir Kondratyev Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4gyqcB4Ldwz45XG X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- On Sat, 11 Jul 2026 at 20:21, Kyle Evans wrote: > > On 5/22/26 02:41, ShengYi Hung wrote: > > The branch main has been updated by aokblast: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=28d85db46b484589e2ee74cf4b270db066821de1 > Hi, > > This patch reliably fixes a bug I've been trying to track down in a u2f(4) patch > that I've been testing, and I'm wondering if you can help connect the dots. I > have a Solo2 u2f(4) key that I find will inconsistently desync (for other reasons) > and hang, and the solution for *that* is to release this NOT_YET block[0] in > u2f_dtor(). > > The problem I was hunting down is that doing so subsequently broke my Yubikey in a > way that this patch alone seems to fix. It would hang on every other ssh attempt, as > long as we issued usbd_transfer_stop on our interrupt endpoints upon last-close. It > was known to work with uhid(4) reliably which issues a stop as well, and that's the > thing I can't really explain. Is there something that uhid(4) / usb_dev.c is doing > that might have accidentally worked around this? > > This was the only commit that looked relevant in the fast-forward I did for my latest > round of testing from 9c18d55a768a3 to 707ee7ff952c5, and reverting just this patch > reliably re-introduces the problem I was having with the Yubikey. > My guess is the yubikey device firmware pays attention to this bit and the state is only reset when the state cycles through STOP. If you're curious, try comparing usbdump captures before/after the fix and look for explicit differences in things and then guess what the firmware is doing. -adrian