From owner-cvs-all Fri Jul 12 9:30:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CB1D137B400; Fri, 12 Jul 2002 09:30:36 -0700 (PDT) Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F1B943E6D; Fri, 12 Jul 2002 09:30:35 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g6CGUYY94545; Fri, 12 Jul 2002 10:30:34 -0600 (MDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g6CGUSG31751; Fri, 12 Jul 2002 10:30:33 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 12 Jul 2002 10:30:11 -0600 (MDT) Message-Id: <20020712.103011.56126329.imp@bsdimp.com> To: dl@catspoiler.org Cc: hsu@FreeBSD.org, truckman@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet udp_usrreq.c From: "M. Warner Losh" In-Reply-To: <200207121628.g6CGS3wr014471@gw.catspoiler.org> References: <20020712.101645.125311016.imp@bsdimp.com> <200207121628.g6CGS3wr014471@gw.catspoiler.org> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <200207121628.g6CGS3wr014471@gw.catspoiler.org> Don Lewis writes: : On 12 Jul, M. Warner Losh wrote: : > In message: <0GZ4004U3MZCIJ@mta5.snfc21.pbi.net> : > Jeffrey Hsu writes: : > : > Lock inp while we're accessing it. : > : : > : Here's a rhetorical question: why? That inp was purposely left unlocked. : > : > I can only assume that he didn't have enough: : > : > ../../../vm/uma_core.c:1332: could sleep with "inp" locked from ../../../netinet/tcp_usrreq.c:536 : > : > messages in his dmesg log. : : I checked in a fix for that violation last night. SYSCTL_OUT() can : block, so calling it with a lock held will cause this error. This : particular case was easy to fix by moving the call to SYSCTL_OUT() : outside the locked region. :-) I was trying to make a small joke, but if you have fixed this violation for real, I'll be very happy :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message