From owner-svn-src-all@freebsd.org Thu May 11 11:30:26 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBA78D6565C for ; Thu, 11 May 2017 11:30:26 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay05.ispgateway.de (smtprelay05.ispgateway.de [80.67.31.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B3ACB1883; Thu, 11 May 2017 11:30:26 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from [78.35.155.27] (helo=fabiankeil.de) by smtprelay05.ispgateway.de with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.84) (envelope-from ) id 1d8mGM-0000xI-6W; Thu, 11 May 2017 13:28:06 +0200 Date: Thu, 11 May 2017 12:55:14 +0200 From: Fabian Keil To: Gleb Smirnoff Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r318166 - head/sys/netinet Message-ID: <20170511125514.6714f872@fabiankeil.de> In-Reply-To: <201705102332.v4ANWVGW007216@repo.freebsd.org> References: <201705102332.v4ANWVGW007216@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/x0z4jbxxNV68R/mjLWE_plZ"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 11:30:27 -0000 --Sig_/x0z4jbxxNV68R/mjLWE_plZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Gleb Smirnoff wrote: > Author: glebius > Date: Wed May 10 23:32:31 2017 > New Revision: 318166 > URL: https://svnweb.freebsd.org/changeset/base/318166 >=20 > Log: > There is no good reason for TCP reassembly zone to be UMA_ZONE_NOFREE. > =20 > It has strong locking model, doesn't have any timers associated with > entries. The entries theirselves are referenced only from the tcpcb > zone, which itself is a normal zone, without the UMA_ZONE_NOFREE flag. A side effect of the UMA_ZONE_NOFREE flag is that allocations with M_NOWAIT (currently used tcp_reass()) are less likely to fail. Removing the UMA_ZONE_NOFREE in other TCP-related parts "recently" caused (still unfixed) regressions like: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209680 It would be great if there was a method to reserve a certain number of items for the zone without having to rely on UMA_ZONE_NOFREE but last time I checked there wasn't one. Fabian --Sig_/x0z4jbxxNV68R/mjLWE_plZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTKUNd6H/m3+ByGULIFiohV/3dUnQUCWRRDEwAKCRAFiohV/3dU nTA5AJwPwD46UZaGdLP7ZOt23QLHMOLRvgCeMxzH8CUVwWKgHSTRLcLRvAt911U= =Tz+z -----END PGP SIGNATURE----- --Sig_/x0z4jbxxNV68R/mjLWE_plZ--