Date: Thu, 11 May 2017 12:55:14 +0200 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r318166 - head/sys/netinet Message-ID: <20170511125514.6714f872@fabiankeil.de> In-Reply-To: <201705102332.v4ANWVGW007216@repo.freebsd.org> References: <201705102332.v4ANWVGW007216@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/x0z4jbxxNV68R/mjLWE_plZ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Gleb Smirnoff <glebius@FreeBSD.org> wrote: > Author: glebius > Date: Wed May 10 23:32:31 2017 > New Revision: 318166 > URL: https://svnweb.freebsd.org/changeset/base/318166 >=20 > Log: > There is no good reason for TCP reassembly zone to be UMA_ZONE_NOFREE. > =20 > It has strong locking model, doesn't have any timers associated with > entries. The entries theirselves are referenced only from the tcpcb > zone, which itself is a normal zone, without the UMA_ZONE_NOFREE flag. A side effect of the UMA_ZONE_NOFREE flag is that allocations with M_NOWAIT (currently used tcp_reass()) are less likely to fail. Removing the UMA_ZONE_NOFREE in other TCP-related parts "recently" caused (still unfixed) regressions like: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209680 It would be great if there was a method to reserve a certain number of items for the zone without having to rely on UMA_ZONE_NOFREE but last time I checked there wasn't one. Fabian --Sig_/x0z4jbxxNV68R/mjLWE_plZ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTKUNd6H/m3+ByGULIFiohV/3dUnQUCWRRDEwAKCRAFiohV/3dU nTA5AJwPwD46UZaGdLP7ZOt23QLHMOLRvgCeMxzH8CUVwWKgHSTRLcLRvAt911U= =Tz+z -----END PGP SIGNATURE----- --Sig_/x0z4jbxxNV68R/mjLWE_plZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170511125514.6714f872>