From owner-p4-projects@FreeBSD.ORG  Sat Mar  1 04:02:10 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CAFA61065671; Sat,  1 Mar 2008 04:02:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 809731065673;
	Sat,  1 Mar 2008 04:02:09 +0000 (UTC) (envelope-from haro@kgt.co.jp)
Received: from mail02.kgt.co.jp (dmz02.kgt.co.jp [210.141.246.82])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E50A8FC17;
	Sat,  1 Mar 2008 04:02:09 +0000 (UTC) (envelope-from haro@kgt.co.jp)
Received: from navgw.tt.kgt.co.jp (unknown [210.141.246.71])
	by mail02.kgt.co.jp (Postfix) with ESMTP id 3763C3C3DD41;
	Sat,  1 Mar 2008 12:51:25 +0900 (JST)
Received: from localhost (posh.tt.kgt.co.jp [192.168.15.51])
	by navgw.tt.kgt.co.jp (Postfix) with ESMTP
	id 0099747711; Sat,  1 Mar 2008 12:51:24 +0900 (JST)
Date: Sat, 01 Mar 2008 12:49:23 +0900 (JST)
Message-Id: <20080301.124923.69822602.haro@kgt.co.jp>
To: obrien@FreeBSD.org
From: haro@kgt.co.jp
In-Reply-To: <200802291948.m1TJmHX0092569@repoman.freebsd.org>
References: <200802291948.m1TJmHX0092569@repoman.freebsd.org>
X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 136469 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Mar 2008 04:02:10 -0000

From: "David E. O'Brien" <obrien@FreeBSD.org>
Date: Fri, 29 Feb 2008 19:48:17 GMT
::http://perforce.freebsd.org/chv.cgi?CH=136469
::
::Change 136469 by obrien@obrien_trang on 2008/02/29 00:22:37
::
::	Zero out the new tcb.
::	Obtained from: Juniper Networks
::
::Affected files ...
::
::.. //depot/projects/mips2-jnpr/src/lib/libthr/arch/mips/mips/pthread_md.c#3 edit
::
::Differences ...
::
::==== //depot/projects/mips2-jnpr/src/lib/libthr/arch/mips/mips/pthread_md.c#3 (text+ko) ====
::
::@@ -42,6 +42,7 @@
:: 
:: 	tcb = malloc(sizeof(struct tcb));
:: 	if (tcb)
::+		bzero(tcb, sizeof(struct tcb));
:: 		tcb->tcb_thread = thread;
:: 	return (tcb);
:: }

Hi 

Shouldn't we need '{', '}' around the 'if (tcb)' ?

Thanks,
 Haro
=-----------------------------------------------------------------------
           _ _    Munehiro (haro) Matsuda
 -|- /_\  |_|_|   KGT Inc.
 /|\ |_|  |_|_|   2-8-8 Shinjuku, Shinjuku-ku Tokyo 160-0022, Japan
                  Tel: +81-3-3225-0767  Fax: +81-3-3225-0740