From owner-cvs-all Mon Dec 4 12:33:17 2000 From owner-cvs-all@FreeBSD.ORG Mon Dec 4 12:33:13 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [207.154.226.10]) by hub.freebsd.org (Postfix) with ESMTP id 42CF437B400; Mon, 4 Dec 2000 12:33:13 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1098) id B6C712B249; Mon, 4 Dec 2000 14:33:12 -0600 (CST) Date: Mon, 4 Dec 2000 14:33:12 -0600 From: Bill Fumerola To: David O'Brien Cc: Jeroen Ruigrok van der Werven , cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/usr.bin/tail forward.c read.c reverse.c tail Message-ID: <20001204143312.B75794@elvis.mu.org> References: <200012031705.eB3H5ke30393@freefall.freebsd.org> <20001204202406.A64100@lucifer.bart.nl> <20001204122458.A46610@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20001204122458.A46610@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Mon, Dec 04, 2000 at 12:24:58PM -0800 X-Operating-System: FreeBSD 4.2-FEARSOME-20001103 i386 Sender: billf@elvis.mu.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Dec 04, 2000 at 12:24:58PM -0800, David O'Brien wrote: > > What would be the point in leaving it in? > > REDUCE THE DIFFs. Maybe I am the only one that often goes and reads > diffs and logs back to the very beginning.. but if the change is a NOP, > why make it? What is this new Young Turks movement to totally change > style(9)?? One of the big advantages of FreeBSD is the code in a > *single* place, following a rather *standard* layout. This really > improves the readability of the code base. Reducing the diffs may be the exact reason for removing. Other *BSDs have long since removed them from some of the code in cleanups. > Why don't you talk to others about it too rather than just ones that > strongly back *your* opinion? Please consider listening to the Gray > Beards. (and yes I own both the C89, C99, and C++ standards) Can I have the obrien-approved list of people I can get reviews from? -- Bill Fumerola - security yahoo / Yahoo! inc. - fumerola@yahoo-inc.com / billf@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message