Date: Thu, 20 Mar 2008 09:51:22 +0100 From: Roman Divacky <rdivacky@FreeBSD.org> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: freebsd-emulation@FreeBSD.org Subject: Re: [PATCH]: additional futex operations Message-ID: <20080320085122.GB32936@freebsd.org> In-Reply-To: <20080320080703.ws5h2vaqskkw4w0s@webmail.leidinger.net> References: <96317980@ipt.ru> <20080319204521.GA98846@freebsd.org> <20080320080703.ws5h2vaqskkw4w0s@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 20, 2008 at 08:07:03AM +0100, Alexander Leidinger wrote: > Quoting Roman Divacky <rdivacky@FreeBSD.org> (from Wed, 19 Mar 2008 > 21:45:21 +0100): > > > > >can you guys please test: > > > > www.vlakno.cz/~rdivacky/futex_private_pi.patch > > > >especially if linux-firefox is still broken with this patch. > > What do you think about rate limiting (only one) the FD case instead > of hiding it completely (and using the content of the comment as the > message to print with a little bit of "only report if something is > obviously broken")? This way we could determine if we need it for > linux-backwards compatibility. I dont think the FD case is used widely and we correctly (now) return ENOSYS so no problems should be here. Also.. if anyone is willing/able to implement the FD backing I think such person is skilled enough to see what is the problem even without the printf. It can only confuse normal people I think.. I'd let it be as it is > Is this a proof of concept (do you plan to make a no-op > LINUX_FUTEX_PRIVATE_FLAG case in the switch to be consistent) or the > final solution? I see pros/cons for both and I think it doesn't matter > how it is done, I'm just curious about your opinion. we DO implement private futexes. we DONT implement shared ones. We dont share futexes on "vm" structure or file descriptor. The only reason why it works is because 99% of application want private futexes but dont claim so :) > Extremely nit-pickicking mode (you can silently ignore it): > s/But it/It/ > s/any sense/sense/ I'll reword the comment as kib@ requested.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080320085122.GB32936>