From owner-cvs-all Fri Jan 31 10:31:23 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BD6A437B401 for ; Fri, 31 Jan 2003 10:31:21 -0800 (PST) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4063043F93 for ; Fri, 31 Jan 2003 10:31:20 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 28103 invoked from network); 31 Jan 2003 18:31:24 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 31 Jan 2003 18:31:24 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0VIVHUT072497; Fri, 31 Jan 2003 13:31:18 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Fri, 31 Jan 2003 13:31:23 -0500 (EST) From: John Baldwin To: Julian Elischer Subject: RE: cvs commit: src/sys/kern subr_trap.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, "Tim J. Robbins" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 31-Jan-2003 Julian Elischer wrote: > > do you know of any other problems? thread_statclock() has a similar problem as others have noticed: int thread_statclock(int user) { struct thread *td = curthread; ... if (td->td_mailbox != NULL) td->td_usticks += ticks; } Prior to this commit, the 'ticks' variable was an argument to this function, now it is using the global variable instead. This is clearly wrong and along with the other breakages this commit has introduced so far demonstrate a severe lack of testing or review in this commit. We want to make RELENG_5 more stable as we approach 5.1 not less if possible. There is nothing preventing you from doing development work in side trees and only committing it when it is tested and has been properly reviewed. Please back these changes out and work on them locally until you have tested them and fully reviewed them. > > On Fri, 31 Jan 2003, John Baldwin wrote: > >> >> On 31-Jan-2003 Tim J. Robbins wrote: >> > tjr 2003/01/31 03:22:32 PST >> > >> > Modified files: >> > sys/kern subr_trap.c >> > Log: >> > Use a local variable to store the number of ticks that elapsed in >> > kernel mode instead of (unintentionally) using the global `ticks'. >> > This error completely broke profiling. >> >> Perhaps we should really back out the 'upcall' change until the patch >> has has some more review and bugs like this have been fixed. >> >> -- >> >> John Baldwin <>< http://www.FreeBSD.org/~jhb/ >> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ >> > -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message