From owner-svn-src-all@freebsd.org Sat Nov 30 19:25:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 420B41B48E6; Sat, 30 Nov 2019 19:25:11 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47QLtZ3KvQz4N2k; Sat, 30 Nov 2019 19:25:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x642.google.com with SMTP id o8so9933019pls.5; Sat, 30 Nov 2019 11:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=VFJDaNy6j7tfv4LV2KrFXJbJEq5JTNFO+4Qd08wh7yw=; b=NZxGgx68FV6aIiL51kburuqdbH8iq9KkKw9fOptLXQZ4wkiqAfS2Y8/bJSzNCm53g0 kaAcWlbH5YIP4ZERVILinm4oNzHNjrvFSAsl6QX1E4wIxuqpsHAKpyGuFeF4fba+DAgo wD5o/amhDXT+5kPk6kydcSU7AnWwteT7bJ1mLLMCfQXM2NCNm2HMAHQdLPssqcOIwpyh WASXbm2KKxZ8LwTRuGlZLOlEEV6x6gmSpKDx19eHXjcz+5oMyZPiFRRdCP3c9cFPWqgW qX3qlhTNR/4CstddBFRAK4vO1n3SZegqLxyjZjD1avdbuxXps5PUsbJITkPf46AVuCFS vhhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=VFJDaNy6j7tfv4LV2KrFXJbJEq5JTNFO+4Qd08wh7yw=; b=GCAlQz1hBaziW3wGvnjjvGpZGIqyFMih9XJs3EnOLWUg5Zwhox8FUvrRGt7S7Jwk1T nbkrWsszeALfFeMuxAhWKA0PxghoC0KDfPf+4S5NhnvgQiUT8b5kC0PU7psG02qvTAsl efGGrGNXUKzVNn/5wune4VAw683nrXgf+ZGEXLQ53NvM09Vh3WxokvXWbbx9fHalBUk/ ZiZ/xWtKkL9shkLNClnfzzQrDOZ1bjCQX2zjQ3fqKcES3G8KaczCdNcintjOCTojVASM ktZgU+eZxFZOYS2dfY9mHXeg0/4YyTC81FeQZRvqGxoER0CVIRr4PSOPv8XdzleqURhT BtBw== X-Gm-Message-State: APjAAAVGqI1DW3Tzi6SL4ui1P60m7GTA4LRLEbFvMklrSSSqQLEX4ZG7 m8jvR4eHkI9YH1U6fb90kS0/7CelX40= X-Google-Smtp-Source: APXvYqw9TIqaaz/gsAZdvC1vOLMcKHRocAmpXkcXmHqTNQKRpxns8qZSSM/jR4EKsQtRPEvDvN5RBA== X-Received: by 2002:a17:902:6b4b:: with SMTP id g11mr20116546plt.196.1575141908990; Sat, 30 Nov 2019 11:25:08 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c9sm28785972pfn.65.2019.11.30.11.25.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Nov 2019 11:25:08 -0800 (PST) From: Enji Cooper Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm Date: Sat, 30 Nov 2019 11:25:07 -0800 In-Reply-To: Cc: Scott Long , src-committers , svn-src-all , svn-src-head To: Warner Losh References: <201911280232.xAS2WHtb029602@repo.freebsd.org> <41D40355-A16E-48E1-9C11-0C9E42C83A42@gmail.com> X-Mailer: Apple Mail (2.3601.0.10) X-Rspamd-Queue-Id: 47QLtZ3KvQz4N2k X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NZxGgx68; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::642 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RECEIVED_SPAMHAUS_PBL(0.00)[228.52.19.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(0.00)[ip: (-0.53), ipnet: 2607:f8b0::/32(-2.25), asn: 15169(-1.94), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Nov 2019 19:25:11 -0000 > On Nov 30, 2019, at 11:01 AM, Warner Losh wrote: >=20 > On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper > wrote: >=20 >> On Nov 30, 2019, at 10:03 AM, Warner Losh > wrote: >>=20 >>=20 >>=20 >> On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper > wrote: >>=20 >> > On Nov 27, 2019, at 6:32 PM, Scott Long > wrote: >> >=20 >> > Author: scottl >> > Date: Thu Nov 28 02:32:17 2019 >> > New Revision: 355164 >> > URL: https://svnweb.freebsd.org/changeset/base/355164 = >> >=20 >> > Log: >> > Remove the trm(4) driver >> >=20 >> > Differential Revision: https://reviews.freebsd.org/D22575 = >>=20 >> Hi Scott, >> I believe this driver was removed because it was impacts the = CAM GIANT lock removal effort =E2=80=94 is that true (I=E2=80=99m asking = because the =E2=80=9Cwhy=E2=80=9D behind the removal is unclear)? >>=20 >> Hi Enji, >>=20 >> We're trying hard to get rid of all Giant-locked drivers in the tree, = either by updating or removal. Since sym(4) provides a super-set of = trm(4) and we have recent-ish reports of sym(4) working, it makes sense = to trim this driver from the tree. The specific cards it supports aren't = all that popular, the couple-extra features that trm(4) gave over sym(4) = aren't really that relevant today, and it's been years since trm has had = good testing and maintenance. >=20 > Warner, > Thanks so very much for the info :). Glad to see this effort = taking place, since it=E2=80=99s very needed to modernize FreeBSD and = improve concurrency in the kernel, as well as reduce the overall = maintenance burden. >=20 > Giant isn't contending, but it's getting in the way of a cleanup of = the console / kbd system, as well as there being newbus issues in highly = dynamic systems. With TB and USB4 support on the horizon, we need to = finally clean that mess up.. I'll post a longer summary of what's left. = I have a 'doodle' tree that I'm separating out the Giant usage to = 'driver lock', kbd/console/ddb, newbus, sysctl, and WTF is that = protecting... I'm tempted to create wtf_lock() and wtf_unlock(), but I'm = not sure how well that would go over :) Sounds great :D=E2=80=A6 -Enji PS wtf_lock() would be amusing, but probably less of a good idea these = days :D...=