Date: Sat, 28 Feb 2015 23:58:51 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197786] [PATCH] math/pspp: Bump PORTREVISION, take maintainership Message-ID: <bug-197786-13-G0zWyPy59S@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197786-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197786-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197786 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cpm@fbsd.es Attachment #153632| |maintainer-approval?(cpm@fb Flags| |sd.es) --- Comment #5 from Jan Beich <jbeich@FreeBSD.org> --- Created attachment 153632 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D153632&action= =3Dedit alternative version Maybe also install Emacs mode for syntax highlightling and facilitating indentation/commenting in .sps files. >+OPTIONS_DEFAULT=3D DOCS NLS Already there, see Mk/bsd.options.mk. >+post-install: >+.for f in libpspp libpspp-core >+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/${PORTNAME}/${f}-${PORTVERSION}.so >+.endfor >+ >+.if ${PORT_OPTIONS:MGUI} >+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/glade3/modules/libglade-psppire.so= .0.0.0 Why? install-strip is enough or you can simplify the following GUI_INSTALL_TARGET=3D install-strip ... GUI_INSTALL_TARGET_OFF=3D install-strip into INSTALL_TARGET=3D install-strip GUI_INSTALL_TARGET=3D ... > +DOCS=3D ABOUT-NLS AUTHORS COPYING ChangeLog INSTALL NEWS ONEWS \ > + README THANKS TODO > + [...] > + ${MKDIR} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC} && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} [...] > +%%PORTDOCS%%%%DOCSDIR%%/ABOUT-NLS > +%%PORTDOCS%%%%DOCSDIR%%/AUTHORS > +%%PORTDOCS%%%%DOCSDIR%%/COPYING > +%%PORTDOCS%%%%DOCSDIR%%/ChangeLog > +%%PORTDOCS%%%%DOCSDIR%%/INSTALL > +%%PORTDOCS%%%%DOCSDIR%%/NEWS > +%%PORTDOCS%%%%DOCSDIR%%/ONEWS > +%%PORTDOCS%%%%DOCSDIR%%/README > +%%PORTDOCS%%%%DOCSDIR%%/THANKS > +%%PORTDOCS%%%%DOCSDIR%%/TODO Unless you want to keep everything in one place at the expense of listing installed files several times the above can be simplified to: PORTDOCS=3D AUTHORS ChangeLog NEWS ONEWS README THANKS TODO (cd ${WRKSRC} && ${COPYTREE_SHARE} \ "${PORTDOCS}" ${STAGEDIR}${DOCSDIR}) ABOUT-NLS is generic help-file from gettext. COPYING is redundant because LICENSE=3DGPLv3 already installs /usr/ports/Templates/Licenses/GPLv3. INSTALL is pointless for people using the FreeBSD port/package and not trying to figure out how to compile pspp themselves. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197786-13-G0zWyPy59S>