From owner-freebsd-net@freebsd.org  Tue Mar 15 06:23:26 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC127AD131E
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Tue, 15 Mar 2016 06:23:26 +0000 (UTC)
 (envelope-from mmcco@mykolab.com)
Received: from mx-out02.mykolab.com (mx01.mykolab.com [95.128.36.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 963B81C9A
 for <freebsd-net@freebsd.org>; Tue, 15 Mar 2016 06:23:25 +0000 (UTC)
 (envelope-from mmcco@mykolab.com)
X-Virus-Scanned: amavisd-new at kolabnow.com
X-Spam-Flag: NO
X-Spam-Score: -2.9
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 tagged_above=-10 required=6.31
 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, FREEMAIL_FROM=0.001,
 RP_MATCHES_RCVD=-0.001] autolearn=ham
Received: from mx04.mykolab.com (mx04.mykolab.com [10.20.7.102])
 by mx-out02.mykolab.com (Postfix) with ESMTPS id 456CB6565E;
 Tue, 15 Mar 2016 07:23:21 +0100 (CET)
Date: Tue, 15 Mar 2016 02:23:17 -0400
From: Michael McConville <mmcco@mykolab.com>
To: Ben Woods <woodsb02@gmail.com>
Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
Subject: Re: Int overflow in dhclient(1)
Message-ID: <20160315062316.GC344@thinkpad.swarthmore.edu>
References: <20160315015542.GA61626@thinkpad.swarthmore.edu>
 <CAOc73CCVaK5DEAhkyg9P1=oKo2vhj7xDNPhHJDJixS+-0uALmA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAOc73CCVaK5DEAhkyg9P1=oKo2vhj7xDNPhHJDJixS+-0uALmA@mail.gmail.com>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2016 06:23:26 -0000

Ben Woods wrote:
> On Tuesday, 15 March 2016, Michael McConville <mmcco@mykolab.com> wrote:
> 
> > I sent this a few weeks ago, but it never got applied:
> >
> > https://marc.info/?l=freebsd-net&m=145392057613453&w=2
> >
> > Here's my explanation for the same fix in OpenBSD:
> >
> > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2
> >
> > Thanks for your time,
> > Michael
> >
> >
> > Index: sbin/dhclient/dhclient.c
> > ===================================================================
> > --- sbin/dhclient/dhclient.c    (revision 296886)
> > +++ sbin/dhclient/dhclient.c    (working copy)
> > @@ -138,7 +138,7 @@
> >  findproto(char *cp, int n)
> >  {
> >         struct sockaddr *sa;
> > -       int i;
> > +       unsigned int i;
> >
> >         if (n == 0)
> >                 return -1;
> >
> 
> Seems like a bug report should be raised so this one doesn't get
> lost/ignored.
> 
> Would you be able to raise one here please?
> https://bugs.freebsd.org/

I'll wait a day or two to see if a developer picks it up. Opening a bug
report is a lot of work for a pretty straight-forward addition of a
single token.