Date: Sat, 23 Jan 2010 17:30:04 GMT From: Eugene Grosbein <egrosbein@rdtc.ru> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/143096: [PATCH] net/AquaGatekeeper: use $SUB_FILES to dynamically adjust pkg-message Message-ID: <201001231730.o0NHU4xd091609@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/143096; it has been noted by GNATS. From: Eugene Grosbein <egrosbein@rdtc.ru> To: bug-followup@FreeBSD.ORG Cc: Subject: Re: ports/143096: [PATCH] net/AquaGatekeeper: use $SUB_FILES to dynamically adjust pkg-message Date: Sat, 23 Jan 2010 23:40:56 +0700 This is a multi-part message in MIME format. --------------050309000908030507080204 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit The intent is of submitter is good but patch needs some polishing. While I'm here, make more useful changes to the port: - support cross-platform installation by suppression of striping for precompiled binary; - change MAINTAINER e-mail to another one with less strict antispam policy; - group ARCH-dependent lines together; - replace dead WWW link with living mirror; - make it clearly visible that the software is effectively "abadonware" for now. I'm not requesting deletion of the port because I still see some interest in it periodically and it still runs fine but there should be clear statement that this soft is dying. Corrected patch is in the attachment, please commit. Eugene Grosbein --------------050309000908030507080204 Content-Type: text/plain; name="agk.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="agk.patch" diff -urN AquaGatekeeper.orig/Makefile AquaGatekeeper/Makefile --- AquaGatekeeper.orig/Makefile 2009-01-06 08:09:28.000000000 +0700 +++ AquaGatekeeper/Makefile 2010-01-23 23:34:17.000000000 +0700 @@ -13,7 +13,7 @@ ftp://www.kuzbass.ru/pub/FreeBSD/ports/distfiles/ EXTRACT_SUFX= .tgz -MAINTAINER= eugen@grosbein.pp.ru +MAINTAINER= ports@grosbein.pp.ru COMMENT= Aqua H323 Gatekeeper and proxy WRKSRC= ${WRKDIR}/${PORTNAME} @@ -22,6 +22,10 @@ MD5_FILE= ${MASTERDIR}/distinfo.${ARCH} RESTRICTED= No commercial redistribution +SUB_FILES= pkg-message +STRIP= +STRIP_CMD= ${TRUE} +DEPRECATED= Binary port of software abadonned by the vendor .if !defined(BATCH) && !defined(PACKAGE_BUILDING) IS_INTERACTIVE= yes @@ -46,20 +50,17 @@ post-install: @${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL - @${SED} "s'%%PREFIX%%'${PREFIX}'" < pkg-message + @${CAT} ${PKGMESSAGE} .include <bsd.port.pre.mk> +# This is binary port of closed-source software .if ${ARCH} == "i386" +DISTNAME= AquaGatekeeper122FreeBSDBuild445 LIB_DEPENDS= c.4:${PORTSDIR}/misc/compat4x .elif ${ARCH} == "amd64" -LIB_DEPENDS= c.5:${PORTSDIR}/misc/compat5x -.endif - -.if ${ARCH} == "amd64" DISTNAME= AquaGatekeeper122FreeBSDamd64Build131 -.else -DISTNAME= AquaGatekeeper122FreeBSDBuild445 +LIB_DEPENDS= c.5:${PORTSDIR}/misc/compat5x .endif .include <bsd.port.post.mk> diff -urN AquaGatekeeper.orig/files/pkg-message.in AquaGatekeeper/files/pkg-message.in --- AquaGatekeeper.orig/files/pkg-message.in 1970-01-01 07:00:00.000000000 +0700 +++ AquaGatekeeper/files/pkg-message.in 2010-01-23 23:32:28.000000000 +0700 @@ -0,0 +1,9 @@ +**************************************************************************** +!!! NOTE: THE AQUA GATEKEEPER IS DISCONTIUED BY ITS VENDOR. No vendor support, +!!! no updates, no bugfixes. This port is still provided to support +!!! old installations only. You should choose other software for new setups. + + Please read documentation located in %%DOCSDIR%% + You will need to write configuration file to run the Gatekeeper. + Some examples are in %%EXAMPLESDIR%% +**************************************************************************** diff -urN AquaGatekeeper.orig/pkg-descr AquaGatekeeper/pkg-descr --- AquaGatekeeper.orig/pkg-descr 2003-11-03 00:37:14.000000000 +0700 +++ AquaGatekeeper/pkg-descr 2010-01-23 23:32:28.000000000 +0700 @@ -6,7 +6,11 @@ It is not a free software but may be used free of charge. The Aqua Gatekeeper Startup Edition is limited to 30 concurrent calls. -WWW: http://www.aqua.comptek.ru/man/voip/gatekeeper/index.htm +!!! NOTE: THE AQUA GATEKEEPER IS DISCONTIUED BY ITS VENDOR. No vendor support, +!!! no updates, no bugfixes. This port is still provided to support +!!! old installations only. You should choose other software for new setups. + +WWW: http://www.kuzbass.ru/docs/AquaGatekeeper/AquaGatekeeper.htm - Grosbein -eugen@grosbein.pp.ru +ports@grosbein.pp.ru diff -urN AquaGatekeeper.orig/pkg-message AquaGatekeeper/pkg-message --- AquaGatekeeper.orig/pkg-message 2003-11-03 00:37:14.000000000 +0700 +++ AquaGatekeeper/pkg-message 1970-01-01 07:00:00.000000000 +0700 @@ -1,5 +0,0 @@ -**************************************************************************** - Please read documentation located in %%PREFIX%%/share/doc/AquaGatekeeper - You will need to write configuration file to run the Gatekeeper. - Some examples are in %%PREFIX%%/share/examples/AquaGatekeeper -**************************************************************************** --------------050309000908030507080204--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001231730.o0NHU4xd091609>