From owner-cvs-src@FreeBSD.ORG Mon Feb 7 16:56:25 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4208C16A4CE for ; Mon, 7 Feb 2005 16:56:25 +0000 (GMT) Received: from mail23.sea5.speakeasy.net (mail23.sea5.speakeasy.net [69.17.117.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id C428043D46 for ; Mon, 7 Feb 2005 16:56:24 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 16666 invoked from network); 7 Feb 2005 16:56:24 -0000 Received: from server.baldwin.cx ([216.27.160.63]) (envelope-sender )AES256-SHA encrypted SMTP for ; 7 Feb 2005 16:56:21 -0000 Received: from [10.50.40.202] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id j17GuFjf086694; Mon, 7 Feb 2005 11:56:15 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Ian Dowse Date: Mon, 7 Feb 2005 10:15:39 -0500 User-Agent: KMail/1.6.2 References: <200502061655.j16GtqDK033151@repoman.freebsd.org> In-Reply-To: <200502061655.j16GtqDK033151@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200502071015.39224.jhb@FreeBSD.org> X-Spam-Status: No, score=-102.8 required=4.2 tests=ALL_TRUSTED, USER_IN_WHITELIST autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/random probe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2005 16:56:25 -0000 On Sunday 06 February 2005 11:55 am, Ian Dowse wrote: > iedowse 2005-02-06 16:55:52 UTC > > FreeBSD src repository > > Modified files: > sys/dev/random probe.c > Log: > Check that we have at least a 586-class CPU before calling do_cpuid(). > This fixes booting on a number of 486 processors. This is wrong. Some 486's do have cpuid, notable the dx4's (I used to have one.) The correct test is to see if you can flip a bit in %eflags (can't remember which one). If that flag stays at zero then you don't have cpuid, if the bit follows the value written to it then you do have cpuid. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org