Date: Wed, 9 Mar 2022 20:52:59 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 78564b68723f - stable/13 - Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. Message-ID: <202203092052.229KqxiK062303@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=78564b68723f53bdd854da4e5cedf740289e956e commit 78564b68723f53bdd854da4e5cedf740289e956e Author: Scott Long <scottl@FreeBSD.org> AuthorDate: 2022-02-26 17:25:43 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-03-09 20:52:23 +0000 Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. (cherry picked from commit e28289ca83673d753b7e479810947f6a1015ad39) --- sys/dev/smartpqi/smartpqi_helper.c | 2 +- sys/dev/smartpqi/smartpqi_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_helper.c b/sys/dev/smartpqi/smartpqi_helper.c index 809677c7cc1e..b49fb2d5a718 100644 --- a/sys/dev/smartpqi/smartpqi_helper.c +++ b/sys/dev/smartpqi/smartpqi_helper.c @@ -98,7 +98,7 @@ void pqisrc_configure_legacy_intx(pqisrc_softstate_t *softs, boolean_t enable_intx) { uint32_t intx_mask; - uint32_t *reg_addr = NULL; + uint32_t *reg_addr __unused; DBG_FUNC("IN\n"); diff --git a/sys/dev/smartpqi/smartpqi_init.c b/sys/dev/smartpqi/smartpqi_init.c index 1f127cff21ec..6a9cca23f72d 100644 --- a/sys/dev/smartpqi/smartpqi_init.c +++ b/sys/dev/smartpqi/smartpqi_init.c @@ -590,7 +590,7 @@ pqisrc_process_config_table(pqisrc_softstate_t *softs) int ret = PQI_STATUS_FAILURE; uint32_t config_table_size; uint32_t section_off; - uint8_t *config_table_abs_addr; + uint8_t *config_table_abs_addr __unused; struct pqi_conf_table *conf_table; struct pqi_conf_table_section_header *section_hdr;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202203092052.229KqxiK062303>