From nobody Sun Mar 29 18:35:32 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fkNNh5k76z6X7Hs for ; Sun, 29 Mar 2026 18:35:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fkNNh3cZ6z3RKH for ; Sun, 29 Mar 2026 18:35:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774809332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QqQK1xLLm6mQHwxGY/pQgQZQm8usBf19oa2gwbBpDVk=; b=A665OaYr7ly/JWECmMfl/nxx6mcxu4k1s5yCSOoPkynvO9mwyjW2bxziHoK80H3nl8FiMv epcnU7/AzsUJwmoVVsRPNLKXtlLJ764/ltBvpUbHjWhH8Fs5ZF4GZUOlz/NVBdCmAU0eMR GtAgZ1FGNHRLKRDavCusB1Mq+vKcjrLJFA1ISp9CxcbU16qBYEcWB3EemwqvpBQ+6d5URg LnP83Lste5CP0OHJV36UrLm9hncLpMBRbr01oyYiQECZ2Tl4BdSl1xC+4sNvDvTalNeANH afv9bF8mlGM3JQuJj/AEVReq/GxTfd0gBIq9g6kw14tg+krbS6zCim/UgKTecw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774809332; a=rsa-sha256; cv=none; b=i/q5QtE8z18dNzkKhholGDZggaqD8nbJN+zA9daBD0MdCPloeLiP2Hg1BJBHDW+mPMTTF7 h3GyuI+4g9ZYwPlTAKhX0i+JQeFKKeZM0IOV99EtwPlfTnRPlny2hSrl2KkCrTrAO02a1M ZmKiO6htskosZyLRA/Yo4TqffPa/t8GEwTY/519VzHgCD6Wud9d1xCNlb1P0Sk+1qByvAE OArZkgm2tOsjHBJYI7gXO6EvWoM8+1n5F/8zd+1IrDPBIFMDQdwuWVcPUxQ8vmjLFETiJQ fTtqQf4x/dYlXPb5dZdmHLbVAYZ6jslHJ56t8uXiJZVBoA4OeXkIOOKATElTMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774809332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QqQK1xLLm6mQHwxGY/pQgQZQm8usBf19oa2gwbBpDVk=; b=dK/sMrt9ttiDfkyXtqPuxwYO8bV3hlnCdW7IpOimkZPyTXc64TcmdXVJOD2e/ynPb5WIgt 0UrNVlVRg3eO3imy4OBAUJshvy8sgkw0uhI9Gx7/uuft2iUBdPliwkeNRau1f7LCngUXmE ISRoLzDAleVkJCzLEiPHRcUAVuC2eaZe4DCLUQXC1PUsDsHRGvh/lQHSlK2knL2uwCvcHC 2kjJn2eD+OnjxOt6VkYAyCeHPTNUbGD/s4OWrk7hXsECFBaW9vkv15EqyP1/8mEAwcvPr9 2WkcYqXEI+L94QvbM8F0gJIby3RyCzos1OBO/GGXdZW/kZt7fRPBfuMhaDMw/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fkNNh394Sz1Mhq for ; Sun, 29 Mar 2026 18:35:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19a55 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 29 Mar 2026 18:35:32 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Salychev Subject: git: 5812415bee55 - main - dpaa2: Perform bus_dma pre-write sync before enqueue operation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dsl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5812415bee55a9063508b02fda9418b0eadb0bb4 Auto-Submitted: auto-generated Date: Sun, 29 Mar 2026 18:35:32 +0000 Message-Id: <69c970f4.19a55.1c610811@gitrepo.freebsd.org> The branch main has been updated by dsl: URL: https://cgit.FreeBSD.org/src/commit/?id=5812415bee55a9063508b02fda9418b0eadb0bb4 commit 5812415bee55a9063508b02fda9418b0eadb0bb4 Author: Dmitry Salychev AuthorDate: 2026-03-28 18:57:45 +0000 Commit: Dmitry Salychev CommitDate: 2026-03-29 18:34:09 +0000 dpaa2: Perform bus_dma pre-write sync before enqueue operation Without a proper synchronization payload of the egress TCP segments can be corrupted as tuexen@ described in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292006#c31. This patch is indirectly related to 292006 because a properly enabled and announced support for the TX checksum offloading hides potentially corrupted frame payload. NOTE: Returned back with updated placeholders. PR: 292006 Reported by: tuexen@ Reviewed by: tuexen@ Tested by: dsl@, tuexen@ Differential Revision: https://reviews.freebsd.org/D56144 MFC after: 3 days --- sys/dev/dpaa2/dpaa2_ni.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/dpaa2/dpaa2_ni.c b/sys/dev/dpaa2/dpaa2_ni.c index c72e68b8a62f..49e72c8ee14f 100644 --- a/sys/dev/dpaa2/dpaa2_ni.c +++ b/sys/dev/dpaa2/dpaa2_ni.c @@ -3004,6 +3004,9 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, goto err_unload; } + bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); + bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); + /* TODO: Enqueue several frames in a single command */ for (int i = 0; i < DPAA2_NI_ENQUEUE_RETRIES; i++) { /* TODO: Return error codes instead of # of frames */ @@ -3013,9 +3016,6 @@ dpaa2_ni_tx(struct dpaa2_ni_softc *sc, struct dpaa2_channel *ch, } } - bus_dmamap_sync(buf->dmat, buf->dmap, BUS_DMASYNC_PREWRITE); - bus_dmamap_sync(sgt->dmat, sgt->dmap, BUS_DMASYNC_PREWRITE); - if (rc != 1) { fq->chan->tx_dropped++; if_inc_counter(sc->ifp, IFCOUNTER_OERRORS, 1);