Date: Thu, 21 Dec 2017 00:36:44 +0000 From: Eric Joyner <erj@erj.cc> To: Ian Lepore <ian@freebsd.org> Cc: Mark Johnston <markj@freebsd.org>, cramerj@intel.com, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327031 - in head/sys: conf dev/ixgbe modules/ix modules/ixv Message-ID: <CAKdFRZibmyRBqE0MBJc=vZkHCZijeZV-KT5dkzPViB9WVUC9Kw@mail.gmail.com> In-Reply-To: <1513800135.29087.25.camel@freebsd.org> References: <201712201815.vBKIF6IN062349@repo.freebsd.org> <20171220193237.GA11032@raichu> <CAKdFRZjwVQXEcUVGBKQkPV7Fn3tuqqqS2oOW5gAAaVtbp1q4tg@mail.gmail.com> <1513800135.29087.25.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 20, 2017 at 12:02 PM Ian Lepore <ian@freebsd.org> wrote: > On Wed, 2017-12-20 at 19:47 +0000, Eric Joyner wrote: > > On Wed, Dec 20, 2017 at 11:32 AM Mark Johnston <markj@freebsd.org> > wrote: > > > > > > > > On Wed, Dec 20, 2017 at 06:15:06PM +0000, Eric Joyner wrote: > > > > > > > > Author: erj > > > > Date: Wed Dec 20 18:15:06 2017 > > > > New Revision: 327031 > > > > URL: https://svnweb.freebsd.org/changeset/base/327031 > > > > > > > > Log: > > > > ixgbe(4): Convert driver to use iflib > > > > [...] > > > This seems to have broken at least the i386 kernel build. Could you > > > please take a look? > > > > > > https://ci.freebsd.org/job/FreeBSD-head-i386-build/5330/console > > > > We probably missed this because we pretty much only use amd64 for > testing; > > it looks like for that error we can just change that ULONG to a UQUAD. > I'll > > add Jeb to this thread. > > > > - Eric > > A good way to avoid such trouble when touching kernel/module code that > compiles on multiple arches is to do a "make lintkernels". > > Before you can do that, you need to do "make kernel-toolchains" just > once, which may take a while -- it has to build clang for each arch, > which is a bit annoying since every instance of clang is already a > cross-compiler and our build process doesn't make use of that fact. > > -- Ian > > Thanks for the report and tips, guys. It should be fixed in r327051. An i386 build didn't show any other errors. - Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKdFRZibmyRBqE0MBJc=vZkHCZijeZV-KT5dkzPViB9WVUC9Kw>