From owner-freebsd-net@FreeBSD.ORG  Thu Mar 26 21:24:35 2015
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2A593CF0
 for <freebsd-net@freebsd.org>; Thu, 26 Mar 2015 21:24:35 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F3F8EC62
 for <freebsd-net@freebsd.org>; Thu, 26 Mar 2015 21:24:34 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t2QLOYpT054592
 for <freebsd-net@freebsd.org>; Thu, 26 Mar 2015 21:24:34 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t2QLOYib054591;
 Thu, 26 Mar 2015 21:24:34 GMT (envelope-from root)
Date: Thu, 26 Mar 2015 21:24:34 +0000
To: freebsd-net@freebsd.org
From: "kristof (Kristof Provost)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1944: PF and VIMAGE fixes
Message-ID: <e57c1efbeb331ae6821219250c58febc@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1944: PF and VIMAGE fixes
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-cc3fb6vejhnh7xhqtpkr>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-wsgmn2xibp2yi52xz6fn>
X-Phabricator-To: <PHID-USER-d4twv4w2hsoq7prc6boa>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-ejqqvwsrqxen3vd3xete>
X-Phabricator-Cc: <PHID-MLST-crbi54kg7ihel5ezzzmu>
X-Phabricator-Cc: <PHID-MLST-5lcr2rqsbmuavxbsw4mm>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-clct73g5zt63yh3lvwzr-req@FreeBSD.org>
Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFUUeRI=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2015 21:24:35 -0000

kristof added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_ioctl.c:325 It's not clear to me why this is done here, rather than in pf_unload(). The initialisation is done in pf_load() after all.
  sys/netpfil/pf/pf_ioctl.c:3725 Don't we still need to do all of this somewhere?

REVISION DETAIL
  https://reviews.freebsd.org/D1944

To: nvass-gmx.com, gnn, bz, zec, trociny, glebius, rodrigc, kristof
Cc: freebsd-virtualization, freebsd-pf, freebsd-net