From owner-svn-src-all@FreeBSD.ORG Fri Apr 9 13:08:12 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57EE9106564A; Fri, 9 Apr 2010 13:08:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 088058FC0A; Fri, 9 Apr 2010 13:08:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o39D2uBC062522; Fri, 9 Apr 2010 07:02:56 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 09 Apr 2010 07:03:00 -0600 (MDT) Message-Id: <20100409.070300.771721883854029283.imp@bsdimp.com> To: netchild@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20100409092721.19743kgds231hckg@webmail.leidinger.net> References: <20100407100015.117169nw2iu6xp4w@webmail.leidinger.net> <20100408.151213.718265677801106795.imp@bsdimp.com> <20100409092721.19743kgds231hckg@webmail.leidinger.net> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: kostikbel@gmail.com, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r206082 - in head: . share/man/man7 share/mk sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2010 13:08:12 -0000 In message: <20100409092721.19743kgds231hckg@webmail.leidinger.net> Alexander Leidinger writes: : Quoting "M. Warner Losh" (from Thu, 08 Apr 2010 : 15:12:13 -0600 (MDT)): : : > In message: <20100407100015.117169nw2iu6xp4w@webmail.leidinger.net> : > Alexander Leidinger writes: : > : Quoting "M. Warner Losh" (from Tue, 06 Apr 2010 : > : 10:54:17 -0600 (MDT)): : > : : > : > In message: : > <20100405181450.13494itjj2ehj5og@webmail.leidinger.net> : > : > Alexander Leidinger writes: : > : > : Warner, do you mind if I back-out r206082 and change the place : > where : > : > : NORMAL_CTFCONVERT is used instead (fist I have to search for it : > : > : again... not today)? It would make it consistent with all other : > : > places : > : > : (SYSTEM_CTFCONVERT and the plain test and use of CTFxxx). : > : > : > : > Go ahead. I just did the fast and dirty fix. I though it was : > : > consistent with how other things were done, but if not, feel free : > to : > : > correct it. Also, see bde's commentary :) : > : : > : I can not find it, can you please forward it to me? : > : > Will do. : > : > : Here is what I have ATM (copy&paste, so tabs are probably mangled): : > : ---snip--- : > : Index: usr.sbin/config/mkmakefile.c : > : =================================================================== : > : --- usr.sbin/config/mkmakefile.c (revision 206031) : > : +++ usr.sbin/config/mkmakefile.c (working copy) : > : @@ -741,7 +741,7 @@ : > : printf("config: don't know rules for %s\n", : > : np); break; : > : } : > : - snprintf(cmd, sizeof(cmd), "${%s_%c%s}\n.if : > : - defined(NORMAL_CTFCONVERT) && : > : - !empty(NORMAL_CTFCONVERT)\n\t${NORMAL_CTFCONVERT}\n.endif", : > : - ftype, : > : + snprintf(cmd, sizeof(cmd), "${%s_%c%s}\n\t@${NORMAL_CTFCONVERT}", : > : ftype, : > : toupper(och), : > : ftp->f_flags & NOWERROR ? "_NOWERROR" : ""); : > : compilewith = cmd; : > : > Uggg, this should have never been put into mkmakefile.c in the first : > place. I'm concerned that a change like this will have bad effects : > for people that have cross-threaded config and kernels. :( : : You need to have a look at the complete code, there is more than only : the use of NORMAL_CTFCONVERT. Regarding the cross-case, I think it can : be done by overriding NORMAL_CTFCONVERT (if needed). I have looked at the complete code. config has no business knowing about these things. It is a layering violation. It must be removed from config. However, since you didn't put it there, you should do the next best thing and fix the bug in the current implementation. : > However, go ahead and fix it. I worry about people with : > cross-threaded kernels, but that won't be a huge deal, I don't think. : > Please monitor the lists to make sure... : : Do I understand this right, that you think I shall do it before I get : the forwarded mail? I think you should commit this fix. I'll forward you bde's mail and you can work on another fix. In the mean time (after you commit the patch we're talking about right now), please monitor hackers@ and current@ for any problems. Warner