From owner-svn-ports-all@FreeBSD.ORG  Sat Nov 10 13:50:01 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 510F5503; Sat, 10 Nov 2012 13:50:01 +0000 (UTC)
Date: Sat, 10 Nov 2012 13:50:01 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Jason E. Hale" <jhale@freebsd.org>
Subject: Re: svn commit: r307265 - head/multimedia/xmms
Message-ID: <20121110135000.GA19769@FreeBSD.org>
References: <201211100944.qAA9i1aM075322@svn.freebsd.org>
 <8250312.uWLkCNKtQT@mocha.verizon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <8250312.uWLkCNKtQT@mocha.verizon.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2012 13:50:01 -0000

On Sat, Nov 10, 2012 at 08:20:37AM -0500, Jason E. Hale wrote:
> On Saturday, November 10, 2012 09:44:01 Alexey Dokuchaev wrote:
> > New Revision: 307265
> > URL: http://svnweb.freebsd.org/changeset/ports/307265
> > 
> > Log:
> >   Apparently, in some cases (per what I observe here) using empty(...) for
> >   testing specific PORT_OPTIONS instead of kosher ! breaks the build.  Fix
> >   this.  While here, move the test below the target.
> > 
> That's because it should just be:
> .if empty(PORT_OPTIONS:MSIMD)
> 
> The ${...} should be removed.  The ! works too, but isn't any more kosher.

Shit, you're right!  I guess at this time point it does not make any sense to
change it back though (it's consistent with recommended way and I personally
like it better :-).

./danfe