Date: Tue, 20 Nov 2018 19:42:01 -0800 From: Yuri <yuri@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r485493 - in head/misc: . sdformat sdformat/files Message-ID: <943a26a7-e363-8a16-7b7a-5086dfe18b06@freebsd.org> In-Reply-To: <in0r-xi8k-wny@FreeBSD.org> References: <201811210216.wAL2Gpqd090066@repo.freebsd.org> <in0r-xi8k-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/20/18 6:43 PM, Jan Beich wrote: > Why not just add TEST option and run after build when enabled? > > OPTIONS_DEFINE= TEST > > TEST_CMAKE_BOOL= BUILD_TESTING > TEST_TEST_TARGET= test > > pre-install-TEST-on: do-test > Because the option will remain in the package. Once installed, the TEST option has no meaning. With TEST=on or TEST=off the package is exactly the same, which defeats the meaning of the option. On the other hand, with the custom 'do-test' target only the test target is added without any extra port options. Yuri
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?943a26a7-e363-8a16-7b7a-5086dfe18b06>