From nobody Mon Feb 2 17:18:31 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4YHC4Wmfz6QlT1 for ; Mon, 02 Feb 2026 17:18:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4YHC1q1sz3YD0 for ; Mon, 02 Feb 2026 17:18:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770052711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ElL3AiuOViMo/oP0k3zOPAGs+opXd7dbNih6Ey9m0r4=; b=L/RXLJ3ltCZuMZ9Ftyz1/LhFtN4UGiVb0SUpATDZYC6xhIPkrHldfxWw8A7XgvCskjUzK9 zYdo7L8TKs8NihhaB9TPHfqI9Fy47DUKAhxVerVfegcXyKI1zpYR2Kzrj/oODiUsq+A/OX DbG6D+g8WclfDpqsPaPh7MDNmgliXZzY+vYA0Jj1dw40mltbJwpQI3lJQF9pgvgT5x/t6D dH9kc6PoxGC7DI4/aBkL8qnPujZ5/poEopGXX0ZzvJiSickuezUd8axeORje4wFXO7cihT O1vMcl2ZapL0i479omv9o7QUZ2eV/wNB/Ntf6DNepZSiGH8yhUylRNU6H6rhKg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770052711; a=rsa-sha256; cv=none; b=sRWf1cxa8mpQVgAzSDc2Ic3k/QWq9Yrinsx9M3dW+u/H5JmVDsmfEj+EfHQgQkDzH1p5fv XROiBC4+kaQLTy8kT0YXZmPWefKbe9n8zUhpMA1bDiH6zn+hcuV7gvugkBKcOVXIW22Edn wOnYXY2L3nDdUL3PQn/fIkuMWymHFIa7RkNPEfLlBuvvow70VrcWzQF0vbuFMXNKXRItGi gZFL7Evzq8cXVffymu8gQBSvY5PeqKncoBL3OG9tfpQmOxc22Y5ub6Mk4BO0owKlIOfPpK PMX06gPpVa7iU7wio10O0XtRCloBaL0BP1mHgh2GJfhzBLOmmnauoTe7zFY4HA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770052711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ElL3AiuOViMo/oP0k3zOPAGs+opXd7dbNih6Ey9m0r4=; b=iu7UbaYpV7338c1nXn7d9ZtWDR5rBGB8vIP4iTwDeWg+RH9FMHWKqVc9Ql8h6ZAzsKEwHM HfEIOLzlWanL9FOoC5ZhttpuvYdUh2CeB+zANVEAVsE8+/wTzAbVvhowJfwaZzPd59hvlh ofpOlha4N0RSQzZuwHUXz6RuikNOMdmACyv7+0JE4G6hwNe1G+etdmnJjjrtA+vxsNXNxs acPge9mtgPdkcd7rMFHIKKIZkvBEu5Y8+N09qWWIlcFO70YXLVvGnjpBFQmqi2/3id+gMw WNyV4bnr2vz+qD+wQm8vmF66XTKJTb9Io4ZqEvjHaE6i05XnEyzAxW3/WQ5Tew== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4YHC1738zc0c for ; Mon, 02 Feb 2026 17:18:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1ebca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 17:18:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 03d8ac948b1a - main - heimdal: Pass the correct pointer to realloc when growing a string buffer List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 03d8ac948b1ad9c419b294c3129b7da58d818363 Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 17:18:31 +0000 Message-Id: <6980dc67.1ebca.59c053b@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=03d8ac948b1ad9c419b294c3129b7da58d818363 commit 03d8ac948b1ad9c419b294c3129b7da58d818363 Author: John Baldwin AuthorDate: 2026-02-02 17:18:11 +0000 Commit: John Baldwin CommitDate: 2026-02-02 17:18:11 +0000 heimdal: Pass the correct pointer to realloc when growing a string buffer The realloc in my_fgetln was trying to grow the pointer to the string buffer, not the string buffer itself. In function 'my_fgetln', inlined from 'mit_prop_dump' at crypto/heimdal/kdc/mit_dump.c:156:19: crypto/heimdal/kdc/mit_dump.c:119:13: error: 'realloc' called on unallocated object 'line' [-Werror=free-nonheap-object] 119 | n = realloc(buf, *sz + (*sz >> 1)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ crypto/heimdal/kdc/mit_dump.c: In function 'mit_prop_dump': crypto/heimdal/kdc/mit_dump.c:139:11: note: declared here 139 | char *line = NULL; | ^~~~ Reviewed by: rmacklem, cy Fixes: a93e1b731ae4 ("heimdal-kadmin: Add support for the -f dump option") Differential Revision: https://reviews.freebsd.org/D54933 --- crypto/heimdal/kdc/mit_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/kdc/mit_dump.c b/crypto/heimdal/kdc/mit_dump.c index 4397d1ad897d..d790b145af11 100644 --- a/crypto/heimdal/kdc/mit_dump.c +++ b/crypto/heimdal/kdc/mit_dump.c @@ -116,7 +116,7 @@ my_fgetln(FILE *f, char **buf, size_t *sz, size_t *len) return 0; } *len += strlen(&(*buf)[*len]); /* *len should be == *sz */ - n = realloc(buf, *sz + (*sz >> 1)); + n = realloc(*buf, *sz + (*sz >> 1)); if (!n) { free(*buf); *buf = NULL;