From owner-freebsd-net Wed Jul 24 22:12:58 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB67837B400 for ; Wed, 24 Jul 2002 22:12:55 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DF0143E31 for ; Wed, 24 Jul 2002 22:12:55 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g6P5CrpO018153; Wed, 24 Jul 2002 22:12:53 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g6P5Cqd7018152; Wed, 24 Jul 2002 22:12:52 -0700 Date: Wed, 24 Jul 2002 22:12:52 -0700 From: Brooks Davis To: Bruce Evans Cc: net@FreeBSD.ORG Subject: Re: ppp(4) cloning review request Message-ID: <20020724221252.A17223@Odin.AC.HMC.Edu> References: <20020723225859.A20811@Odin.AC.HMC.Edu> <20020724232548.W33495-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020724232548.W33495-100000@gamplex.bde.org>; from bde@zeta.org.au on Wed, Jul 24, 2002 at 11:36:50PM +1000 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 24, 2002 at 11:36:50PM +1000, Bruce Evans wrote: > On Tue, 23 Jul 2002, Brooks Davis wrote: >=20 > > I have attached a patch which adds cloning and unloading support to the > > ppp(4) kernel PPP device. I would like to commit it in the next few > > days. Please review. > > ... > > - The unload is a bit ugly because line disciplines don't really > > appear to be meant to be unhooked. >=20 > There is ldisc_deregister(). Using it might require using ldisc_register= () > instead of rudely hacking on linesw[]. if_sl.c also has rude hacks, but > there are examples of using these interfaces in snp and netgraph. Thanks for the pointer. That helps a bit. Looking at the way line disciplines are used, I can't help but think that the current method of accessing them by index is a bit stupid. It's rather odd to have support for loadable disciplines, but no standard way to find out what is in each slot. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --AqsLC8rIMeq19msA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9P4jUXY6L6fI4GtQRAtQNAKDIM7AqWb3BEdOQMH0dRyzsuReTngCguGY0 y88r9ny3jrBwEhsouAYoalA= =ZC5+ -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message