From owner-svn-src-all@freebsd.org Thu Apr 25 18:27:21 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD6F1159EA37; Thu, 25 Apr 2019 18:27:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 645229299A; Thu, 25 Apr 2019 18:27:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 03AF07DA3; Thu, 25 Apr 2019 18:27:21 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f47.google.com with SMTP id j20so530573lfh.2; Thu, 25 Apr 2019 11:27:20 -0700 (PDT) X-Gm-Message-State: APjAAAWKM8sL0lOgVFfITUwoM+LfBRsooPDTBbRfvizz/6+cPDAd1W1g uX6JJIawdePwMeAm54CvVCyxcJANu21tLk+dfxs= X-Google-Smtp-Source: APXvYqz0LRiwL5a0W2YUzjx223JAmpgSbyoiCHXa/5aYjXwhb7QTX+KRrjR4UgpNaxi39oATPm5vZgTtJC1gEEcMFpE= X-Received: by 2002:a19:7d04:: with SMTP id y4mr4238642lfc.153.1556216839732; Thu, 25 Apr 2019 11:27:19 -0700 (PDT) MIME-Version: 1.0 References: <201904251822.x3PIMN71083387@repo.freebsd.org> <201904251824.x3PIOXmK049366@gndrsh.dnsmgr.net> In-Reply-To: <201904251824.x3PIOXmK049366@gndrsh.dnsmgr.net> From: Kyle Evans Date: Thu, 25 Apr 2019 13:26:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r346688 - head/sys/net To: "Rodney W. Grimes" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 645229299A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2019 18:27:21 -0000 On Thu, Apr 25, 2019 at 1:24 PM Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > Author: kevans > > Date: Thu Apr 25 18:22:22 2019 > > New Revision: 346688 > > URL: https://svnweb.freebsd.org/changeset/base/346688 > > > > Log: > > tap(4): Add a MODULE_VERSION > ^^^ > > > > Otherwise tap(4) can be loaded by loader despite being compiled into the > > kernel, causing a panic as things try to double-initialize. > > > > PR: 220867 > > MFC after: 3 days > > > > Modified: > > head/sys/net/if_tap.c > ^^^ > > > > Modified: head/sys/net/if_tap.c > > ============================================================================== > > --- head/sys/net/if_tap.c Thu Apr 25 18:13:55 2019 (r346687) > > +++ head/sys/net/if_tap.c Thu Apr 25 18:22:22 2019 (r346688) > > @@ -180,6 +180,7 @@ SYSCTL_INT(_net_link_tap, OID_AUTO, devfs_cloning, CTL > > SYSCTL_INT(_net_link_tap, OID_AUTO, debug, CTLFLAG_RW, &tapdebug, 0, ""); > > > > DEV_MODULE(if_tap, tapmodevent, NULL); > ^^^ > > +MODULE_VERSION(if_tun, 1); > ^^^ > If wrong, ok, please fix, if correct, please this needs a very > complete comment as to what it is if_tun. > *sigh* I had one job to do, and I goofed it. Thanks for pointing that out... Kyle Evans