Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Mar 2009 08:53:17 GMT
From:      Cezary Morga <cm@therek.net>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/133086: [maintainer update] Update of editors/p5-Padre to fix pointyhat build problems
Message-ID:  <200903260853.n2Q8rHBP045142@www.freebsd.org>
Resent-Message-ID: <200903260900.n2Q90DPA078171@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         133086
>Category:       ports
>Synopsis:       [maintainer update] Update of editors/p5-Padre to fix pointyhat build problems
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 26 09:00:13 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Cezary Morga
>Release:        FreeBSD 7-STABLE i386
>Organization:
>Environment:
>Description:
- Add IGNORE if Perl without thread support is installed.
- Fix return value for human readable Wx version number.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN editors/p5-Padre.orig/Makefile editors/p5-Padre/Makefile
--- editors/p5-Padre.orig/Makefile	2009-03-26 09:43:15.000000000 +0100
+++ editors/p5-Padre/Makefile	2009-03-26 09:43:41.000000000 +0100
@@ -69,7 +69,13 @@
 USE_PERL5=	5.8.5+
 USE_GETTEXT=	yes
 
-PERL_THREADS=	${PERL} -V::usethreads
+.include <bsd.port.pre.mk>
+
+PERL_THREADS!=	${PERL} -V::usethreads
+
+.if ${PERL_THREADS}!="'define';"
+IGNORE=		needs a threaded Perl, build with WITH_THREADS=yes flag and try again
+.endif
 
 MAN3=		Padre.3 \
 		Padre::Autosave.3 \
@@ -117,16 +123,7 @@
 		Wx::Perl::Dialog::Simple.3 \
 		Wx::Perl::Dialog::SingleChoice.3
 
-pre-configure:
-	@if [ "$$(${PERL_THREADS})" = "'undef';" ]; then \
-		${ECHO_MSG}; \
-		${ECHO_MSG} "===>  ${PKGNAME} requires Perl with thread support built-in!"; \
-		${ECHO_MSG} "      Please, recompile Perl with WITH_THREADS=yes flag and try again."; \
-		${ECHO_MSG}; \
-		exit 2; \
-	fi
-
 post-patch:
 	@${REINPLACE_CMD} -e 's|use File::Spec.*$$||' ${WRKSRC}/lib/Padre/Config/Human.pm
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
diff -ruN editors/p5-Padre.orig/files/patch-inc-Module-Install-PRIVATE-Padre.pm editors/p5-Padre/files/patch-inc-Module-Install-PRIVATE-Padre.pm
--- editors/p5-Padre.orig/files/patch-inc-Module-Install-PRIVATE-Padre.pm	1970-01-01 01:00:00.000000000 +0100
+++ editors/p5-Padre/files/patch-inc-Module-Install-PRIVATE-Padre.pm	2009-03-26 09:43:41.000000000 +0100
@@ -0,0 +1,11 @@
+--- inc/Module/Install/PRIVATE/Padre.pm.orig	2009-03-25 18:14:22.647642180 +0100
++++ inc/Module/Install/PRIVATE/Padre.pm	2009-03-25 18:14:56.500567901 +0100
+@@ -61,7 +61,7 @@
+ 	}
+ 	my $widgets_human = $widgets;
+ 	$widgets_human =~ s/^(\d\.\d\d\d)(\d\d\d)$/$1.$2/;
+-	$widgets_human =~ s/0//g;
++	$widgets_human =~ s/\.0*/./g;
+ 	print "Found wxWidgets $widgets_human\n";
+ 	unless ( $widgets >= 2.008008 ) {
+ 		nono("Padre needs at least version 2.8.8 of wxWidgets. You have wxWidgets $widgets_human");


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903260853.n2Q8rHBP045142>