From owner-svn-src-all@freebsd.org Thu May 5 08:08:34 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D62BB2D206; Thu, 5 May 2016 08:08:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F39F91994; Thu, 5 May 2016 08:08:33 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x232.google.com with SMTP id c189so36344672pfb.3; Thu, 05 May 2016 01:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I5dgWM8u5P94zBSQzZ/CnC/hTd1HztywDi6IJuoJguM=; b=AEcUCX/SgFGVIIqbOGQoV+OQ2obWJyfoLvDGdKur1zxtxdG82bDdYCMqNyWTbZnhjA I3GWmuB0heav4sz0t1w3s69JKQb2ANA77RCBqInhKZJhQxlH4YaVlTc61OPrLP5pGo2D HJ/P2z92vmFcYK/2EeFDHWiA3ILuBtBQ5j3rjJLcS9pSnc7lvzRlb8vnV+70o+RMrNq3 G9EnObVbofBLOr86C6nY1tc2qTkzHrSVz8mAHtpRGCypKnS9//2yTEO775BrnBZ5h6kb Wpn5aNVVX718wHTodbeboxdWEQ9S99yGpfDiZxs5S344uKM5/ZzqA1lObkquxqJjzcs+ Uh1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I5dgWM8u5P94zBSQzZ/CnC/hTd1HztywDi6IJuoJguM=; b=XKsnYFNWqoV8xPpfsptjWormnIMaNDtLfIicBi2FrLRV80J2ZrJgmH+7Mw8vItmUC2 NxUkDQyKvsIsxTK8LEvsyaBl49/tHh1nAVU9bI8bvc/oixXXi4yIAJ2RSf8EYD2TfWE2 02eTaIOM6BcbEknfSbeRxIlBTe0iPqf+VHQuBfFjmdZrC0zlO1FAUd98MMD/NwgVZgwZ DJVeLHUl82T3SvORU0/XMsSCYwARkiJCPt0toc+uDTWVdKp4nDiQJTo17j6YSLTH4qZp ygXSfaGECvJxXnoTsTcfrXQIZhL6+Z7WTfppLPIS5LTpQVaexm8zYKILLuTmc+9c+dKe SOHw== X-Gm-Message-State: AOPr4FXAErNYrEb6eplG7yefHhQczY7DcEy1y//xNISXiKLJcXgQsM1CE5llBowvRpPQ6w== X-Received: by 10.98.88.4 with SMTP id m4mr18399190pfb.71.1462435713575; Thu, 05 May 2016 01:08:33 -0700 (PDT) Received: from [192.168.20.7] (c-73-97-222-46.hsd1.wa.comcast.net. [73.97.222.46]) by smtp.gmail.com with ESMTPSA id 80sm11362799pfx.68.2016.05.05.01.08.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 May 2016 01:08:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r299108 - head/sys/sys From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <2598444.C6bcyDe9AO@ralph.baldwin.cx> Date: Thu, 5 May 2016 01:08:30 -0700 Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7993F466-ADCA-4E82-A258-9E2C7BA8896C@gmail.com> References: <201605050251.u452pVSN034598@repo.freebsd.org> <2598444.C6bcyDe9AO@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 08:08:34 -0000 > On May 4, 2016, at 20:17, John Baldwin wrote: >=20 > On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote: >> Author: ngie >> Date: Thu May 5 02:51:31 2016 >> New Revision: 299108 >> URL: https://svnweb.freebsd.org/changeset/base/299108 >>=20 >> Log: >> Revert r299096 >>=20 >> The change broke buildworld when building lib/libkvm >>=20 >> This change likely needs to be run through a ports -exp run as a = sanity >> check, as it might break downstream consumers. >>=20 >> Pointyhat to: adrian >> Reported by: kargl (confirmed on $work workstation) >> Sponsored by: EMC / Isilon Storage Division >=20 > 'struct foo *' can be use with a simple forward declare in headers = without > requiring header pollution (and is often done for that reason). = device_t > should be used in any .c files, but headers might need to stick with > 'struct device *' in a few cases for that reason. I suspect both of = these > fall into that category. I agree based on the technical point (I didn=E2=80=99t dig into = the why, but it makes sense), but this commit wasn=E2=80=99t even = compile tested. I would rather figure out what the effects are before = reintroducing the change. If this is being done to address compatibility issues with = linuxkpi, I see two paths forward with this (there are probably more..): 1. Convert everything over to device_t (which bde@ disagrees = with), after doing a full tinderbox run and exp- run 2. Localize the =E2=80=9Cshim=E2=80=9D/typedef to linuxkpi so = device_t is used there, or struct device* is used there. Thoughts? -Ngie=