From owner-freebsd-current Wed Jun 6 18:26:19 2001 Delivered-To: freebsd-current@freebsd.org Received: from kyle.tandemedia.com (kyle.tandemedia.com [216.29.169.3]) by hub.freebsd.org (Postfix) with ESMTP id F106737B401; Wed, 6 Jun 2001 18:26:15 -0700 (PDT) (envelope-from rmtodd@ichotolot.servalan.com) Received: by kyle.tandemedia.com (Postfix, from userid 66) id D3F8C55406; Wed, 6 Jun 2001 21:26:14 -0400 (EDT) Received: from ichotolot.servalan.com([127.0.0.1]) (2513 bytes) by servalan.servalan.com via sendmail with P:esmtp/R:smart_host/T:hacked-uux (sender: ) id for ; Wed, 6 Jun 2001 19:37:49 -0500 (CDT) (Smail-3.2.0.111 2000-Feb-17 #1 built 2001-Jan-15) Message-Id: To: current@freebsd.org Cc: peter@freebsd.org Subject: recent change to ata-disk.c seems to be horked... Date: Wed, 06 Jun 2001 19:37:49 -0500 From: Richard Todd Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Just tried to build a kernel with freshly-supped sources and got: cc -c -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -g -nostdinc -I- -I. -I../.. -I../../dev -I../../../include -I../../contrib/dev/acpica -D_KERNEL -include opt_global.h -elf -mpreferred-stack-boundary=2 ../../dev/ata/ata-disk.c ../../dev/ata/ata-disk.c:88: syntax error before `&' ../../dev/ata/ata-disk.c:55: warning: `adopen' used but never defined ../../dev/ata/ata-disk.c:56: warning: `adstrategy' used but never defined ../../dev/ata/ata-disk.c:57: warning: `addump' used but never defined ../../dev/ata/ata-disk.c:58: warning: `ad_cdevsw' defined but not used ../../dev/ata/ata-disk.c:73: warning: `addisk_cdevsw' defined but not used ../../dev/ata/ata-disk.c:76: warning: `ad_invalidatequeue' declared `static' but never defined ../../dev/ata/ata-disk.c:77: warning: `ad_tagsupported' declared `static' but never defined ../../dev/ata/ata-disk.c:78: warning: `ad_timeout' declared `static' but never defined ../../dev/ata/ata-disk.c:79: warning: `ad_free' declared `static' but never defined ../../dev/ata/ata-disk.c:80: warning: `ad_version' declared `static' but never defined ../../dev/ata/ata-disk.c:83: warning: `adp_lun_map' defined but not used ../../dev/ata/ata-disk.c:85: warning: `ata_dma' defined but not used ../../dev/ata/ata-disk.c:86: warning: `ata_wc' defined but not used ../../dev/ata/ata-disk.c:87: warning: `ata_tags' defined but not used *** Error code 1 Stop in /usr/src/sys/compile/ICHOTOLOTSMP. Line 88 is in the diffs that peter just recently committed (rev 1.106; see the commitlogs/sys entry for 2001/06/06 15:17:09 PDT). The offending line is TUNABLE_INT("hw.ata.ata_dma", &ata_dma); Looking at the definition of TUNABLE_INT, it doesn't look like it'd take well to having the 2nd argument (var) be something beginning with &, given that the first thing the definition does is try to define a function based on the var given, in this case static void __Tunable_&ata_dma (void *ignored) See the problem? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message