From owner-freebsd-current Wed May 28 10:14:47 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA22122 for current-outgoing; Wed, 28 May 1997 10:14:47 -0700 (PDT) Received: (from wpaul@localhost) by hub.freebsd.org (8.8.5/8.8.5) id KAA22057; Wed, 28 May 1997 10:12:46 -0700 (PDT) From: Bill Paul Message-Id: <199705281712.KAA22057@hub.freebsd.org> Subject: Re: Duplicate DES code in libc/rpc and secure/lib/des To: ache@nagual.pp.ru (=?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?=) Date: Wed, 28 May 1997 10:12:46 -0700 (PDT) Cc: current@FreeBSD.ORG, markm@FreeBSD.ORG In-Reply-To: from "=?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?=" at May 28, 97 08:42:28 pm X-Mailer: ELM [version 2.4 PL24] Content-Type: text Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > On Wed, 28 May 1997, Bill Paul wrote: > > > > 2) Do we really need to duplicate the same code in several places? > > > I think that secure/lib/des/rpc_* files should be removed. > > > > Er... by secure/lib/des, I'm assuming you mean secure/lib/libdes, > > correct? If so, please tell me exactly which files contain duplicated > > code. Eric Young's libdes has a _des_crypt() routine specially written > > to accomodate Secure RPC, but it shouldn't contain anything in common > > with the actual RPC library (other than maybe a header that describes > > the structure that the RPc code passws to _des_crypt(). > > See secure/lib/libdes/{rpc_des.h,rpc_enc.c} > It seems they can be safely removed > > -- > Andrey A. Chernov > > http://www.nagual.pp.ru/~ache/ rpc_des.h, maybe. But rpc_enc.c can not be removed: this is the file that contains the __des_crypt() routine, which is a wrapper around thr ECB and CBC encryption routines within the library. Keyserv(8) calls into this routine, so it is necessary. I'll let Mark decide if we need the rpc_des.h header. The RPC library itself doesn't require it, but the libdes library as distributed may need it. -Bill